-
Notifications
You must be signed in to change notification settings - Fork 4.6k
TICL-barrel: run CLUE in the barrel calorimeters and first workflows #47859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47859/44499
|
|
A new Pull Request was created by @brusale for master. It involves the following packages:
@AdrianoDee, @Martin-Grunewald, @Moanwar, @antoniovagnerini, @antoniovilela, @bbilin, @civanch, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @jfernan2, @kpedro88, @lviliani, @mandrenguyen, @mdhildreth, @menglu21, @miquork, @mkirsano, @mmusich, @rappoccio, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used: See details on the summary page. |
|
+1 |
|
merge |
|
@cms-sw/generators-l2 Please feel free to sign (or object) retroactively. We wanted to get this one merged as it had to be rebased already several times. |
|
It appears that this PR broke several wf, in the
we're working on a fix. |
this issue is fixed at #48509 |
@smuzaffar in the CLANG-flavoured IB can you clarify what's the action item for this? |
|
@mmusich , may be @makortel can guide you in better direction but what I see is that once you have a May be issue is with https://github.com/cms-sw/cmssw/blob/master/RecoParticleFlow/PFClusterProducer/plugins/BarrelCLUEAlgo.h#L188-L189 but as I wrote @makortel might have better clue [a] [b] |
thanks for the analysis. We are a little puzzled though:
cmssw/RecoParticleFlow/PFClusterProducer/plugins/BarrelLayerClusterPluginFactory.cc Lines 7 to 9 in 6bbdfff
and cmssw/RecoParticleFlow/PFClusterProducer/plugins/BarrelCLUEAlgo.h Lines 184 to 189 in 6bbdfff
VS cmssw/RecoLocalCalo/HGCalRecProducers/plugins/HGCalLayerClusterPluginFactory.cc Lines 9 to 13 in 6bbdfff
and cmssw/RecoLocalCalo/HGCalRecProducers/plugins/HGCalCLUEAlgo.h Lines 242 to 249 in 6bbdfff
|
|
Multiple
less step3_TTbar_14TeV+Run4D110_ProdLike.log
%MSG-w TrackListMerger: TrackListMerger:earlyGeneralTracks 09-Jul-2025 11:12:14 CEST Run: 1 Event: 701
TrackCollection InputTag: label = jetCoreRegionalStepTracks, instance = not found
%MSG----- Begin Fatal Exception 09-Jul-2025 12:32:56 CEST-----------------------
An exception of category 'Configuration' occurred while
[0] Constructing the EventProcessor
[1] Validating configuration of module: class=MergeClusterProducer label='hltMergeLayerClusters'
Exception Message:
Illegal parameters found in configuration. The parameters are named:
'layerClustersEE'
'time_layerclustersEE'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.Full Logs: |
|
@akritkbehera what's the reason of this post? By the way: is unrelated. |
|
Got it, thanks for pointing it out. I missed that comment. @mmusich |
|
@mmusich , looks like fix in #48509 also fixes the CLANG_X relvals. So some strange reason the non-clang relvals were failing before loading and for clang I get |
this issue is followed-up in #48517 |
|
@mmusich @makortel We still observe IB failures for CLANG_X : link Is there a PR or a separate issue where this is being investigated? Thanks! |
I don't think there is a separate issue, could you open one? |
PR description:
This PR adds the possibility of running part of the TICL reconstruction framework in the barrel region. In particular, it introduces the
ticl_barrelprocess modifier with which one can run CLUE in ECAL and HCAL (HO not included), also at HLT, and the corresponding associators and validation chain.With this PR also the first workflows for TICL-barrel are introduced. These workflows run the modules mentioned above at
step2andstep3, and with the HARVESTING one can produce the DQM plots for the LayerClusters in the barrel calorimeters.PR validation:
Tested on wfs
29694.203,29634.0(these two with and withoutticl_barrelprocess modifier) and29753.209(introduced by this PR).@felicepantaleo @rovere @amecca