Skip to content

Conversation

@brusale
Copy link
Contributor

@brusale brusale commented Jul 9, 2025

PR description:

This PR is a follow-up to #47859.
Fix .21 failures due to ProductNotFound errors as explained at #47859 (comment).

PR validation:

runTheMatrix.py -l 29634.21 -i all --ibeos

runs.

fyi @mmusich

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48517/45454

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@mmusich
Copy link
Contributor

mmusich commented Jul 9, 2025

test parameters:

  • workflows = 29634.21, 29834.9921, 29634.402, ph2_hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48517/45455

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@brusale brusale force-pushed the fix_ticlBarrel_prodlike_wfs branch 2 times, most recently from 5c81bc1 to 0c8751e Compare July 9, 2025 14:26
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

A new Pull Request was created by @brusale for master.

It involves the following packages:

  • RecoEgamma/EgammaTools (reconstruction)
  • RecoHGCal/TICL (reconstruction, upgrade)
  • RecoLocalCalo/Configuration (reconstruction)
  • RecoLocalCalo/HGCalRecProducers (reconstruction, upgrade)
  • Validation/Configuration (simulation, dqm)

@Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @ctarricone, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Prasant1993, @ReyerBand, @Sam-Harper, @a-kapoor, @afiqaize, @apsallid, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @forthommel, @hatakeyamak, @jainshilpi, @lecriste, @lgray, @missirol, @pfs, @ram1123, @rovere, @salimcerci, @sameasy, @sethzenz, @sobhatta, @thomreis, @valsdav, @vandreev11, @varuns23, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jul 9, 2025

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Jul 9, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

Pull request #48517 was updated. @Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @ctarricone, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jul 10, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fed139/47175/summary.html
COMMIT: c4e7e81
CMSSW: CMSSW_15_1_X_2025-07-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48517/47175/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.21 step 4
29834.9921 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 26 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 62
  • DQMHistoTests: Total histograms compared: 4387911
  • DQMHistoTests: Total failures: 31
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4387860
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 61 files compared)
  • Checked 267 log files, 228 edm output root files, 62 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jul 10, 2025

urgent

  • fixes IB crashes

@jfernan2
Copy link
Contributor

+1

@mandrenguyen
Copy link
Contributor

+1

@Moanwar
Copy link
Contributor

Moanwar commented Jul 10, 2025

+Upgrade

@kpedro88
Copy link
Contributor

+simulation

@kpedro88
Copy link
Contributor

(noting that further improvements discussed in #48526 should be made in a followup PR)

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit d8b9d39 into cms-sw:master Jul 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants