add vertex trimming to the phase2 hlt tracking iterations #47113

lguzzi · 2025-01-16T10:25:44Z

PR description:

This PR adds vertex trimming to the phase2 hlt menu with a proc. modifier. This modifier allows to select and build only initial step seeds and high-pt triplet step doublets compatible with a subset of pixel vertices.
Preliminary studies of this configuration are available here for the legacy iterations.

update: the LST workflows have been removed from the PR.

PR validation:

This PR has been validated comparing the results of the customisation function used so far with the proc. modifier approach. Comparison plots show no difference.
Efficiency and fake rates for the alpaka and LST configurations are outlined here.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

not needed

cmsbuild · 2025-01-16T10:26:06Z

cms-bot internal usage

cmsbuild · 2025-01-16T10:27:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47113/43320

cmsbuild · 2025-01-16T10:27:36Z

A new Pull Request was created by @lguzzi for master.

It involves the following packages:

Configuration/ProcessModifiers (operations)
HLTrigger/Configuration (hlt)

@Martin-Grunewald, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @mmusich, @rappoccio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @fabiocos, @makortel, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2025-01-16T10:27:59Z

Configuration/ProcessModifiers/python/vertexTrimming_cff.py

+
+# This modifier is used to enable vertex trimming in the tracking sequences
+# and in all related reconstruction modules
+vertexTrimming = cms.Modifier()


can it be renamed to signal it's about the phase-2 HLT?

I renamed it to phase2_hlt_vertexTrimming in c05a4f2

mmusich · 2025-01-16T10:28:12Z

...ration/python/HLT_75e33/modules/hltHighPtTripletStepTrackingRegionFromTrimmedVertices_cfi.py

+    scalingStartNPix        = cms.double(0.0),
+    scalingEndNPix          = cms.double(1.0),
+  ),
+  mightGet = cms.optional.untracked.vstring,


Suggested change

mightGet = cms.optional.untracked.vstring,

unneeded?

done d17f0fb

mmusich · 2025-01-16T10:28:27Z

...ration/python/HLT_75e33/modules/hltHighPtTripletStepTrackingRegionFromTrimmedVertices_cfi.py

+    useFakeVertices         = cms.bool(False),
+    maxNVertices            = cms.int32(-1),
+    nSigmaZ                 = cms.double(4.0),
+    pixelClustersForScaling = cms.InputTag('siPixelClusters'),


this is an offline product?

yes, I copied it from the defaults. It is not used in this configuration, however I changed it to hltSiPixelClusters in d17f0fb

mmusich · 2025-01-16T10:30:17Z

test parameters:

relvals_opt = --what upgrade
workflows = 29634.753, 29634.754, 29634.755, 29634.756, 29634.757, 29634.758, 29634.759, 29634.760, 29634.761
enable = hlt_p2_integration, hlt_p2_timing

mmusich · 2025-01-16T10:32:35Z

@lguzzi please add workflows that can exercise the trimming.
You can take inspiration from the other variants:

cmssw/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

Lines 1647 to 1685 in 547258c

    
           upgradeWFs['HLTTiming75e33Alpaka'] = deepcopy(upgradeWFs['HLTTiming75e33']) 
        
           upgradeWFs['HLTTiming75e33Alpaka'].suffix = '_HLT75e33TimingAlpaka' 
        
           upgradeWFs['HLTTiming75e33Alpaka'].offset = 0.751 
        
           upgradeWFs['HLTTiming75e33Alpaka'].step2 = { 
        
               '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing', 
        
               '--procModifiers': 'alpaka' 
        
           } 
        
           upgradeWFs['HLTTiming75e33TiclV5'] = deepcopy(upgradeWFs['HLTTiming75e33']) 
        
           upgradeWFs['HLTTiming75e33TiclV5'].suffix = '_HLT75e33TimingTiclV5' 
        
           upgradeWFs['HLTTiming75e33TiclV5'].offset = 0.752 
        
           upgradeWFs['HLTTiming75e33TiclV5'].step2 = { 
        
               '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing', 
        
               '--procModifiers': 'ticl_v5' 
        
           } 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIter'] = deepcopy(upgradeWFs['HLTTiming75e33']) 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIter'].suffix = '_HLT75e33TimingAlpakaSingleIter' 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIter'].offset = 0.753 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIter'].step2 = { 
        
               '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing', 
        
               '--procModifiers': 'alpaka,singleIterPatatrack' 
        
           } 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIterLST'] = deepcopy(upgradeWFs['HLTTiming75e33']) 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIterLST'].suffix = '_HLT75e33TimingAlpakaSingleIterLST' 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIterLST'].offset = 0.754 
        
           upgradeWFs['HLTTiming75e33AlpakaSingleIterLST'].step2 = { 
        
               '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing', 
        
               '--procModifiers': 'alpaka,singleIterPatatrack,trackingLST' 
        
           } 
        
           upgradeWFs['HLTTiming75e33AlpakaLST'] = deepcopy(upgradeWFs['HLTTiming75e33']) 
        
           upgradeWFs['HLTTiming75e33AlpakaLST'].suffix = '_HLT75e33TimingAlpakaLST' 
        
           upgradeWFs['HLTTiming75e33AlpakaLST'].offset = 0.755 
        
           upgradeWFs['HLTTiming75e33AlpakaLST'].step2 = { 
        
               '-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:75e33_timing', 
        
               '--procModifiers': 'alpaka,trackingLST' 
        
           }

cmsbuild · 2025-01-16T10:43:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47113/43321

Found files with invalid states:
- Configuration/ProcessModifiers/python/vertexTrimming_cff.py:
  - Added: 8c2f00a
  - Deleted: c05a4f2

cmsbuild · 2025-01-16T10:43:39Z

Pull request #47113 was updated. @Martin-Grunewald, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @mmusich, @rappoccio can you please check and sign again.

mmusich · 2025-01-16T10:50:30Z

Configuration/ProcessModifiers/python/phase2_hlt_vertexTrimming_cff.py

+# This modifier is used to enable vertex trimming in the tracking sequences
+# and in all related reconstruction modules
+phase2_hlt_vertexTrimming = cms.Modifier()
+


this line is uneeded @lguzzi. Anyway please rebase to have just a single commit (also add the requested workflows).

cmsbuild · 2025-01-16T10:51:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47113/43322

Found files with invalid states:
- Configuration/ProcessModifiers/python/vertexTrimming_cff.py:
  - Added: 8c2f00a
  - Deleted: c05a4f2

cmsbuild · 2025-01-16T10:51:31Z

Pull request #47113 was updated. @Martin-Grunewald, @antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @mmusich, @rappoccio can you please check and sign again.

cmsbuild · 2025-04-16T14:50:22Z

Pull request #47113 was updated. @AdrianoDee, @Martin-Grunewald, @Moanwar, @antoniovilela, @cmsbuild, @davidlange6, @DickyChant, @fabiocos, @mandrenguyen, @miquork, @mmusich, @rappoccio, @srimanob, @subirsarkar can you please check and sign again.

mmusich · 2025-04-16T15:05:32Z

please test

cmsbuild · 2025-04-16T17:09:24Z

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee3df1/45583/summary.html
COMMIT: 0cfc125
CMSSW: CMSSW_15_1_X_2025-04-16-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47113/45583/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3916361
DQMHistoTests: Total failures: 52
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3916289
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

mmusich · 2025-04-23T06:22:44Z

+hlt

sign again.

AdrianoDee · 2025-04-23T07:00:34Z

+pdmv

Moanwar · 2025-04-23T08:32:56Z

+Upgrade

cmsbuild · 2025-04-23T08:33:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-04-23T17:08:37Z

+1

cmsbuild added this to the CMSSW_15_0_X milestone Jan 16, 2025

cmsbuild added hlt-pending operations-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jan 16, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 16, 2025

mmusich reviewed Jan 16, 2025

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 16, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 16, 2025

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 16, 2025

mmusich reviewed Jan 16, 2025

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 16, 2025

lguzzi force-pushed the trimming_procModifier branch from d17f0fb to 64612ec Compare January 16, 2025 11:04

cmsbuild removed the code-checks-approved label Jan 16, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 16, 2025

cmsbuild added tests-started and removed tests-pending labels Apr 16, 2025

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Apr 16, 2025

cmsbuild mentioned this pull request Apr 16, 2025

Introduce a single LST-seeded, CKF-building iteration based on Patatrack pixel tracks for Phase 2 HLT #47891

Merged

cmsbuild added hlt-approved and removed hlt-pending labels Apr 23, 2025

cmsbuild added pdmv-approved and removed pdmv-pending labels Apr 23, 2025

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Apr 23, 2025

cmsbuild added orp-approved and removed orp-pending labels Apr 23, 2025

cmsbuild merged commit 0217c92 into cms-sw:master Apr 23, 2025
14 checks passed

cmsbuild mentioned this pull request Apr 23, 2025

Refactor PathsAndConsumesOfModules #47937

Merged

lguzzi deleted the trimming_procModifier branch June 12, 2025 07:52

add vertex trimming to the phase2 hlt tracking iterations #47113

add vertex trimming to the phase2 hlt tracking iterations #47113

Uh oh!

Conversation

lguzzi commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 16, 2025

Uh oh!

cmsbuild commented Jan 16, 2025

Uh oh!

mmusich Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

lguzzi Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

mmusich Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

lguzzi Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

mmusich Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

lguzzi Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

mmusich commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusich commented Jan 16, 2025

Uh oh!

cmsbuild commented Jan 16, 2025

Uh oh!

cmsbuild commented Jan 16, 2025

Uh oh!

mmusich Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jan 16, 2025

Uh oh!

cmsbuild commented Jan 16, 2025

Uh oh!

cmsbuild commented Apr 16, 2025

Uh oh!

mmusich commented Apr 16, 2025

Uh oh!

cmsbuild commented Apr 16, 2025

Comparison Summary

Uh oh!

mmusich commented Apr 23, 2025

Uh oh!

AdrianoDee commented Apr 23, 2025

Uh oh!

Moanwar commented Apr 23, 2025

Uh oh!

cmsbuild commented Apr 23, 2025

Uh oh!

mandrenguyen commented Apr 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

lguzzi commented Jan 16, 2025 •

edited

Loading

cmsbuild commented Jan 16, 2025 •

edited

Loading

mmusich commented Jan 16, 2025 •

edited

Loading