Fix orphan sim clusters

[rovere]

PR description:

Previously, SimClusters were saved regardless of whether the associated
CaloParticle passed the selector criteria. This happened because the DFS
traversal and SimCluster population occurred without checking the
selector status of the current CaloParticle. As a result, SimClusters
belonging to rejected CaloParticles were still saved. This fix ensures
that SimClusters are only saved if their corresponding CaloParticle has
passed the selection.

PR validation:

Checked on some runTheMatrix workflows and there are no more orphan SimClusters.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47883/44523

• There are other open Pull requests which might conflict with changes you have proposed:
  • File SimGeneral/CaloAnalysis/plugins/CaloTruthAccumulator.cc modified in PR(s): TICL-barrel: run CLUE in the barrel calorimeters and first workflows #47859

[cmsbuild]

A new Pull Request was created by @rovere for master.

It involves the following packages:

• SimCalorimetry/HGCalAssociatorProducers (upgrade, simulation)
• SimDataFormats/CaloAnalysis (simulation)
• SimGeneral/CaloAnalysis (simulation)
• SimGeneral/Debugging (simulation)
• SimGeneral/MixingModule (simulation)

@Moanwar, @civanch, @cmsbuild, @kpedro88, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @bsunanda, @denizsun, @fabiocos, @felicepantaleo, @makortel, @martinamalberti, @missirol, @mmusich, @salimcerci, @sameasy, @slomeo, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[rovere]

@AuroraPerego @fabiocos @felicepantaleo @waredjeb

[rovere]

type ngt

[kpedro88]

please test

[cmsbuild]

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abc825/45578/summary.html
COMMIT: a912731
CMSSW: CMSSW_15_1_X_2025-04-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47883/45578/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3916361
• DQMHistoTests: Total failures: 8246
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3908095
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

differences in phase2 WFs are expected.

[rovere]

@cms-sw/upgrade-l2 ping?

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1