Update cms-sw fork of circles #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@smuzaffar is there any way you can resolve the conflict when merging or do I need to open a different PR? |
Refactor scripts to common.js Fix tooltip overflow Fix value sorting Update absolute sorting Add favicon Add save file prompt Add default data folder Zoom on datatable click Fix case sensitive sorting Add ellipses to long element name Fix second column missing arrows Add option to hide animations Fix default behaviour of no dataset selected Fix undefined default unit Visualize selected groups on table
Update DataTables to version 2.2.2 which support more sorting options
|
@mmusich I have resolved the conflicts and merging and deploying it now |
Author
|
thanks @smuzaffar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again as for #4, mostly to update the groupings with the newly unassigned modules, mostly from fwyzard#38 (dealing with cms-sw/cmssw#47859)
I am not sure why the commits already included in #4
are again in the history, but hopefully we can get rid of them when merging).