Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 9, 2025

PR description:

This PR is a follow-up to #47859.
Title says it all, addressed the first part of the issue explained at #47859 (comment).

PR validation:

Run successfully:

runTheMatrix.py -l ph2_hlt -j 8 -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not meant to be backported

@mmusich
Copy link
Contributor Author

mmusich commented Jul 9, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jul 9, 2025

test parameters:

  • workflows = ph2_hlt

@mmusich
Copy link
Contributor Author

mmusich commented Jul 9, 2025

@brusale FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jul 9, 2025

in the last push f992315 I add some more clean-up of unneeded additions from #47859

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

Pull request #48509 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 9, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf01cf/47139/summary.html
COMMIT: f992315
CMSSW: CMSSW_15_1_X_2025-07-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48509/47139/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.751 step 2
29634.753 step 2
29634.754 step 2
29634.755 step 2
29634.7561 step 2
29634.7562 step 2
29634.757 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 458 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4175476
  • DQMHistoTests: Total failures: 61
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4175395
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 247 log files, 208 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jul 9, 2025

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Jul 9, 2025

urgent

  • to fix IB workflows

@cmsbuild cmsbuild added the urgent label Jul 9, 2025
@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e0897b0 into cms-sw:master Jul 9, 2025
11 checks passed
@mmusich mmusich deleted the mm_fix_forTiclBarrel branch July 9, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants