Bugfixes to TICL-barrel

[bfonta]

The PR addresses a series of optimizations and bugfixes concerning TICL-barrel at HLT.

List of fixes

• fix RecHitTools::isBarrel
• ensure an empty barrelRecHitMap is produced whenever its HGCal counterpart is not valid
• replace SimCluster::endcap_hits_and_fractions and SimCluster::barrel_hits_and_fractions by SimCluster::filtered_hits_and_fractions to remove code duplication
• simplify SimCalorimetry/HGCalAssociatorProducers/plugins/LCToCPAssociatorByEnergyScoreProducer.cc and SimCalorimetry/HGCalAssociatorProducers/plugins/LCToSCAssociatorByEnergyScoreProducer.cc
• fix LCToSCAssociatorEDProducer::fillDescriptions()
• optimize Validation/HGCalValidation/src/BarrelVHistoProducerAlgo.cc in the number of layers being used by 2 orders of magnitude
• use the recommended approach to read handles from tokens
• fix minor typos
• part of the original PR was moved into fix ticl barrel in ph-2 HLT configuration #48756 to speed-up its integration.

PR validation:

Tested with the following command on top of CMSSW_15_1_0_pre5:

NEVENTS=24
GEOM="ExtendedRun4D110"
ERA="Phase2C17I13M9"
CONDS="auto:phase2_realistic_T33"
PROCMODS="alpaka,ticl_barrel,ticl_v5"
VALIDSEQ="@hltValidation"
HLTSEQ="NGTScouting"

function mystep2() {
    cmsDriver.py step2 -s L1P2GT,HLT:"${HLTSEQ}",DQM:trackingMonitorHLT,VALIDATION:"${VALIDSEQ}" \
         --conditions "${CONDS}" \
         --datatier GEN-SIM-DIGI-RAW,DQMIO \
         -n ${NEVENTS} \
         --eventcontent FEVTDEBUGHLT,DQMIO \
         --geometry "${GEOM}" \
         --era "${ERA}" \
         --procModifier "${PROCMODS}" \
         --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 \
         --filein file:/eos/cms/store/relval/CMSSW_15_1_0_pre5/RelValTTbar_14TeV/GEN-SIM-DIGI-RAW/PU_150X_mcRun4_realistic_v1_STD_Run4D110_PU-v1/2580000/fc4d8a79-582f-4a08-8fbd-190e161cfdaf.root \
         --fileout file:step2.root \
         --nThreads 24 \
         --process HLTX \
         --inputCommands='keep *, drop *_hlt*_*_HLT, drop triggerTriggerFilterObjectWithRefs_l1t*_*_HLT' 
}

function mystep3() {
    cmsDriver.py step3 -s HARVESTING:"${VALIDSEQ}" \
         --conditions "${CONDS}" \
         --mc \
         --geometry "${GEOM}" \
         --scenario pp \
         --filetype DQM \
         --era "${ERA}" \
         --procModifier "${PROCMODS}" \
         -n ${NEVENTS}  \
         --filein file:step2_inDQM.root \
         --fileout file:step3.root
}

mystep2 && mystep3

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48565/45527

[cmsbuild]

A new Pull Request was created by @bfonta for master.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

test parameters:

• workflows = ph2_hlt

[Martin-Grunewald]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48565/45534

[cmsbuild]

Pull request #48565 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

[iarspider]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20a1a0/47285/summary.html
COMMIT: b09e0e5
CMSSW: CMSSW_15_1_X_2025-07-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48565/47285/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 29634.75

----- Begin Fatal Exception 19-Jul-2025 13:01:30 CEST-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_AK4PFPuppiJet520'
   [2] Calling method for module MergeClusterProducer/'hltMergeLayerClusters'
Exception Message:
ValueMap::Filler: handle and reference collections should the same size
----- End Fatal Exception -------------------------------------------------

• 29634.77

----- Begin Fatal Exception 19-Jul-2025 13:01:33 CEST-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'DST_PFScouting'
   [2] Calling method for module MergeClusterProducer/'hltMergeLayerClusters'
Exception Message:
ValueMap::Filler: handle and reference collections should the same size
----- End Fatal Exception -------------------------------------------------

• 24834.911

----- Begin Fatal Exception 19-Jul-2025 12:53:18 CEST-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'MC_Ele5_Open_Unseeded'
   [2] Calling method for module MergeClusterProducer/'hltMergeLayerClusters'
Exception Message:
ValueMap::Filler: handle and reference collections should the same size
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 29634.772
• 29634.771
• 29634.756
• 29634.759
• 29634.752
• 29696.0
• 29634.911
• 29634.0

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20a1a0/48628/summary.html
COMMIT: ea8d625
CMSSW: CMSSW_16_0_X_2025-10-12-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48565/48628/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

• HLT P2 Timing: chart

Comparison Summary

Summary:

• You potentially added 272 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 65
• DQMHistoTests: Total histograms compared: 4396500
• DQMHistoTests: Total failures: 94
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4396386
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -338.543 KiB( 64 files compared)
• DQMHistoSizes: changed ( 29634.0,... ): -56.152 KiB HGCAL/HGCalValidator
• DQMHistoSizes: changed ( 29753.209 ): -1.631 KiB BarrelCalorimeters/BarrelValidator
• Checked 268 log files, 227 edm output root files, 65 DQM output files
• TriggerResults: no differences found

[bfonta]

The failures were understood 🎉 !
The PR is now ready for review.

[gabrielmscampos]

+dqm

[jfernan2]

+1

[Moanwar]

+Upgrade

[mmusich]

ping @cms-sw/simulation-l2

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

[ftenchini]

+1