Update skipEventsWithoutScoutingByEra for ScoutingNano #49084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g for 2022-24 and disable from 2025
Contributor
|
cms-bot internal usage |
Contributor
|
enable nano |
Contributor
|
test parameters:
|
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49084/46323
|
Contributor
|
A new Pull Request was created by @patinkaew for master. It involves the following packages:
@AdrianoDee, @DickyChant, @Moanwar, @antoniovagnerini, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @ftorrresd, @hqucms, @mandrenguyen, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
please test |
Contributor
|
@cms-sw/xpog-l2 @cms-sw/pdmv-l2 @cms-sw/upgrade-l2 you signed #48984 that got accidentally closed, can you please sign again here? |
Contributor
|
+Upgrade |
Contributor
|
+pdmv |
Contributor
|
+1 |
Contributor
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
cmsbuild
added
operations-approved
fully-signed
tests-approved
and removed
operations-pending
pending-signatures
tests-started
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This was referenced Oct 8, 2025
This was referenced Oct 15, 2025
cmsbuild
added a commit
that referenced
this pull request
Oct 27, 2025
…_1_0_patch1 [15_1_X] Update skipEventsWithoutScoutingByEra for ScoutingNano (backport of #49084)
cmsbuild
added a commit
that referenced
this pull request
Oct 28, 2025
…15_0_15_patch4 [15_0_X] ScoutingNano: Rename era modifier to be more generic (partial backport of #49084)
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR supersedes #48984 which was accidentally closed.
Description copied from the previous PR:
This PR adds
skipEventsWithoutScoutingByErafor ScoutingNano workflow so that this filter is enabled for 2022-24 and disabled for 2025.The new function
skipEventsWithoutScoutingByErais used instead for@ScoutMonitorand@ScoutFromMininanoflavours.The old function
skipEventsWithoutScoutingis kept if ones want to force running this with--customiseargument withcmsDriver.py.As requested by @mmusich, era modifiers are renamed from
run3_scouting_nanoAOD_XXto a more generalrun3_scouting_XXso they can be reused in other tasks, e.g. DQM.Several workflows are added in
relval_nano.pymostly for 2022-23 to ensure the filter is working also with the older data.PR validation:
Validations were done in the previous PR.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is not a backport, but a backport to 15_0_X and 15_1_X will follow.
FYI: @silviodonato @mmusich