Skip to content

Conversation

@jprendi
Copy link
Contributor

@jprendi jprendi commented Oct 10, 2025

backport of #49130

PR description:

This PR introduces a new DQMEDAnalyzer ScoutingMuonPropertiesAnalyzer for further monitoring of the scouting muon collection complimenting ScoutingCollectionMonitor and additions to the ScoutingCollectionMonitor module.

For DQM/HLTEvF/plugins/ScoutingCollectionMonitor.cc and in DQM/Integration/python/clients/scouting_dqm_sourceclient-live_cfg.py, we enable monitoring of multiplicity for all the scouting objects but also IP w.r.t beam spot or dxy, dz w.r.t BS.

N.B.: compared to the initial #49130 to master, we did not turn off monitoring of the calorechits in <= 2024 in this backport, as the backport of #49084 is not available yet

HLTriggerOffline/Scouting/plugins/ScoutingMuonPropertiesAnalyzer.cc and HLTriggerOffline/Scouting/python/ScoutingMuonPropertiesMonitoring_cfi.py is new for the scouting muon properties analyzer.

DQM/HLTEvF/python/ScoutingMuonMonitoring_cff.py, DQMOffline/HLTScouting/python/HLTScoutingDqmOffline_cff.py and HLTriggerOffline/Scouting/plugins/BuildFile.xml were adapted to include the ScoutingMuonPropertiesAnalyzer.

The scouting muon properties analyzer is based of the work done by @prijb here.

PR validation:

We started out with:

cmsrel CMSSW_15_1_X_2025-10-09-2300

cd CMSSW_15_1_X_2025-10-09-2300/src

cmsenv
git cms-addpkg DQM/HLTEvF DQM/Integration DQMOffline/HLTScouting HLTriggerOffline/Scouting
scram b -j
scram b code-format && scram b code-checks
scram b -j


and validated via using the input files at cms-data/DQM-Integration#12 by copying them inside the DQM/Integration/data/run392642 folder and then running:

cmsRun DQM/Integration/python/clients/scouting_dqm_sourceclient-live_cfg.py runInputDir=DQM/Integration/data/ runNumber=392642 scanOnce=True

followed by subsquent inspection of the output histograms.

We also tested the workflow via:


runTheMatrix.py -l  145.415 -t 4 -j 8


Running git cms-checkdeps -a -A shows further dependencies to DQMOffline/Configuration.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #49130 to 15_1_X

@cmsbuild cmsbuild added this to the CMSSW_15_1_X milestone Oct 10, 2025
@jprendi
Copy link
Contributor Author

jprendi commented Oct 10, 2025

type ngt

@cmsbuild
Copy link
Contributor

Pull request #49131 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Oct 10, 2025

test parameters:

  • addpkg = DQM/Integration
  • workflow = 145.415

@mmusich
Copy link
Contributor

mmusich commented Oct 10, 2025

@cmsbuild, please test

@jprendi jprendi marked this pull request as ready for review October 10, 2025 15:58
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2025

A new Pull Request was created by @jprendi for CMSSW_15_1_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQM/Integration (dqm)
  • DQMOffline/HLTScouting (dqm)
  • HLTriggerOffline/Scouting (dqm)

@Martin-Grunewald, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @missirol, @mmusich, @mtosi, @rociovilar, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f087df/48597/summary.html
COMMIT: 6d30a70
CMSSW: CMSSW_15_1_X_2025-10-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49131/48597/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4219791
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4219749
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 26.448 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 26.448 KiB HLT/ScoutingOffline
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich mmusich force-pushed the AdditionsScoutingDQM-15_1_X branch from 6d30a70 to 5a38b44 Compare October 11, 2025 09:50
@cmsbuild
Copy link
Contributor

Pull request #49131 was updated. @Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #49131 was updated. @Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please check and sign again.

@gabrielmscampos
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f087df/48664/summary.html
COMMIT: 9564a5d
CMSSW: CMSSW_15_1_X_2025-10-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49131/48664/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4219791
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4219767
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 27.728 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 27.728 KiB HLT/ScoutingOffline
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@gabrielmscampos
Copy link
Member

+dqm

@mmusich
Copy link
Contributor

mmusich commented Oct 15, 2025

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1bc7839 into cms-sw:CMSSW_15_1_X Oct 16, 2025
9 checks passed
@mmusich mmusich deleted the AdditionsScoutingDQM-15_1_X branch October 16, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants