[15_0_X] ScoutingNano: Rename era modifier to be more generic (partial backport of #49084) #49172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
A new Pull Request was created by @patinkaew for CMSSW_15_0_X. It involves the following packages:
@battibass, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @ftorrresd, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
Contributor
|
cms-bot internal usage |
Contributor
|
backport of #49084 |
Contributor
|
@cmsbuild, please test |
Contributor
Author
|
Hi @mmusich, Thank you so much! I think we should |
Contributor
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
cmsbuild
added
operations-approved
tests-approved
and removed
operations-pending
tests-started
labels
Contributor
|
enable nano |
Contributor
|
test parameters:
|
Contributor
|
@cmsbuild, please test |
cmsbuild
added
operations-pending
tests-started
and removed
operations-approved
tests-approved
labels
Contributor
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
Contributor
|
+xpog |
cmsbuild
added
fully-signed
xpog-approved
and removed
pending-signatures
xpog-pending
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR is a partial backport (first 2 commits) from #49084 to rename era modifiers used in ScoutingNano to be more generic (run3_scouting_nanoAOD_YYYY -> run3_scouting_YYYY) so they can be reused for other tasks, e.g. DQM.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Partial backport of #49084 to 15_0_X.
FYI: @silviodonato @mmusich