Skip to content

Conversation

@akritkbehera
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

A new Pull Request was created by @akritkbehera for branch IB/CMSSW_16_0_X/root636.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

cms-bot internal usage

@akritkbehera
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdab4a/48469/summary.html
COMMIT: 81b61ce
CMSSW: CMSSW_16_0_ROOT636_X_2025-10-03-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10111/48469/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test testFWCoreFWLite had ERRORS

Comparison Summary

Summary:

@akritkbehera
Copy link
Contributor Author

Test parameters:

  • full_cmssw = true

@akritkbehera
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2025

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdab4a/48497/summary.html
COMMIT: 81b61ce
CMSSW: CMSSW_16_0_ROOT636_X_2025-10-03-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10111/48497/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 2 errors in the following unit tests:

---> test testFWCoreFWLite had ERRORS
---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS

Comparison Summary

Summary:

@akritkbehera
Copy link
Contributor Author

please test with cms-sw/cmssw#49103 for CMSSW_16_0_ROOT636_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdab4a/48544/summary.html
COMMIT: 81b61ce
CMSSW: CMSSW_16_0_ROOT636_X_2025-10-06-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10111/48544/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdab4a/48544/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdab4a/48544/git-merge-result

Comparison Summary

Summary:

  • You potentially added 71 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2127 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3940058
  • DQMHistoTests: Total failures: 2213
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3937825
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@makortel , we have not updated root636 for last few weeks, so I will suggest to get this in ROOT636 IBs and debug the unit test failure in the IB. Though cms-sw/cmssw#49103 fixes the unit test for root 636 but we have clang build errors , I guess we can address that failure in the cms-sw/cmssw#49103 .

Merge this in IB we allow us to test latest ROOT 636 changes on bit large scale ( full threaded relvals in IBs)

@smuzaffar
Copy link
Contributor

+externals

though there is a unit test failure but we can look in to that via cms-sw/cmssw#49103

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_0_X/root636 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#49103

@smuzaffar smuzaffar merged commit 91d7189 into cms-sw:IB/CMSSW_16_0_X/root636 Oct 8, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants