-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[DAQ] SFB mode detection of run end flag #49099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49099/46334 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
37874b2 to
53e10a9
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49099/46336 |
|
A new Pull Request was created by @smorovic for master. It involves the following packages:
@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
+daq |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Adding detection of run-end flag set by SFB RU in case of run blocked, out of sync and subsequent end of run which closes files without complete fragment content.
Instead of throwing exception in CMSSW, the process ends run and hltd will take care of closing the lumisection with processed events.
It reused FRD file header V2 used already in L1 Scouting. Data type filed is reused, as L1 Scouting used only values 0-32. Here, value of 0xffff is used for the flag.
PR validation:
Tested with SFB in DAQ3VAL system.
A tect script is also added to the source.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport is planned for 15_1_X and 15_0_X and PRs will follow up