Skip to content

Conversation

@smorovic
Copy link
Contributor

@smorovic smorovic commented Oct 8, 2025

PR description:

Adding detection of run-end flag set by SFB RU in case of run blocked, out of sync and subsequent end of run which closes files without complete fragment content.
Instead of throwing exception in CMSSW, the process ends run and hltd will take care of closing the lumisection with processed events.
It reused FRD file header V2 used already in L1 Scouting. Data type filed is reused, as L1 Scouting used only values 0-32. Here, value of 0xffff is used for the flag.

PR validation:

Tested with SFB in DAQ3VAL system.
A tect script is also added to the source.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport is planned for 15_1_X and 15_0_X and PRs will follow up

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49099/46334

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

A new Pull Request was created by @smorovic for master.

It involves the following packages:

  • EventFilter/Utilities (daq)

@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fwyzard, @missirol this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smorovic
Copy link
Contributor Author

smorovic commented Oct 8, 2025

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

+1

Size: This PR adds an extra 76KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-debfdf/48539/summary.html
COMMIT: 53e10a9
CMSSW: CMSSW_16_0_X_2025-10-07-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49099/48539/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-debfdf/48539/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-debfdf/48539/git-merge-result

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3940073
  • DQMHistoTests: Total failures: 393
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3939660
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smorovic
Copy link
Contributor Author

smorovic commented Oct 8, 2025

+daq

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants