Skip to content

fix HLT TICL reconstruction sequences when ticl_barrel is invoked in presence of the alpaka modifier #48509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Jul 9, 2025
Merged

fix HLT TICL reconstruction sequences when ticl_barrel is invoked in presence of the alpaka modifier #48509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edd15e7
fix HLT TICL reconstruction sequences when ticl_barrel is invoked in …
mmusich Jul 9, 2025
f992315
further clean-up of ticl-barrel related configurations
mmusich Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 41 additions & 18 deletions HLTrigger/Configuration/python/HLT_75e33/modules/hltMergeLayerClusters_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,51 @@
import FWCore.ParameterSet.Config as cms

# Default lists
default_layerClusters = [
"hltHgcalLayerClustersEE",
"hltHgcalLayerClustersHSci",
"hltHgcalLayerClustersHSi"
]

default_time_layerclusters = [
"hltHgcalLayerClustersEE:timeLayerCluster",
"hltHgcalLayerClustersHSci:timeLayerCluster",
"hltHgcalLayerClustersHSi:timeLayerCluster"
]

# Define the producer with default lists
hltMergeLayerClusters = cms.EDProducer("MergeClusterProducer",
layerClusters = cms.VInputTag("hltHgcalLayerClustersEE", "hltHgcalLayerClustersHSci", "hltHgcalLayerClustersHSi"),
mightGet = cms.optional.untracked.vstring,
time_layerclusters = cms.VInputTag("hltHgcalLayerClustersEE:timeLayerCluster", "hltHgcalLayerClustersHSci:timeLayerCluster", "hltHgcalLayerClustersHSi:timeLayerCluster")
layerClusters = cms.VInputTag(*default_layerClusters),
time_layerclusters = cms.VInputTag(*default_time_layerclusters),
)

# Process modifier: alpaka
from Configuration.ProcessModifiers.alpaka_cff import alpaka
alpaka.toModify(hltMergeLayerClusters,
layerClustersEE = cms.InputTag("hltHgCalLayerClustersFromSoAProducer"),
time_layerclustersEE = cms.InputTag("hltHgCalLayerClustersFromSoAProducer", "timeLayerCluster"))
layerClusters = cms.VInputTag(
"hltHgCalLayerClustersFromSoAProducer",
"hltHgcalLayerClustersHSci",
"hltHgcalLayerClustersHSi"
),
time_layerclusters = cms.VInputTag(
"hltHgCalLayerClustersFromSoAProducer:timeLayerCluster",
"hltHgcalLayerClustersHSci:timeLayerCluster",
"hltHgcalLayerClustersHSi:timeLayerCluster"
)
)

# Process modifier: ticl_barrel
from Configuration.ProcessModifiers.ticl_barrel_cff import ticl_barrel

layerClusters = ["hltHgcalLayerClustersEE",
"hltHgcalLayerClustersHSci",
"hltHgcalLayerClustersHSi",
"hltBarrelLayerClustersEB",
"hltBarrelLayerClustersHB"]

time_layerclusters = ["hltHgcalLayerClustersEE:timeLayerCluster",
"hltHgcalLayerClustersHSci:timeLayerCluster",
"hltHgcalLayerClustersHSi:timeLayerCluster",
"hltBarrelLayerClustersEB:timeLayerCluster",
"hltBarrelLayerClustersHB:timeLayerCluster"]

ticl_barrel.toModify(hltMergeLayerClusters, layerClusters = layerClusters, time_layerclusters = time_layerclusters)
ticl_barrel.toModify(hltMergeLayerClusters,
layerClusters = cms.VInputTag(
*default_layerClusters,
"hltBarrelLayerClustersEB",
"hltBarrelLayerClustersHB"
),
time_layerclusters = cms.VInputTag(
*default_time_layerclusters,
"hltBarrelLayerClustersEB:timeLayerCluster",
"hltBarrelLayerClustersHB:timeLayerCluster"
)
)
22 changes: 19 additions & 3 deletions ...ation/python/HLT_75e33/sequences/HLTHgcalTiclPFClusteringForEgammaL1SeededSequence_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,25 @@
from ..modules.hltTiclTracksterLinksL1Seeded_cfi import *
from ..modules.hltBarrelLayerClustersEBL1Seeded_cfi import *

_HgcalLocalRecoL1SeededSequence = cms.Sequence(hltHgcalDigis+hltL1TEGammaHGCFilteredCollectionProducer+hltHgcalDigisL1Seeded+hltHGCalUncalibRecHitL1Seeded+hltHGCalRecHitL1Seeded+hltParticleFlowRecHitHGCL1Seeded+hltRechitInRegionsHGCAL+hltHgcalLayerClustersEEL1Seeded+hltHgcalLayerClustersHSciL1Seeded+hltHgcalLayerClustersHSiL1Seeded+hltMergeLayerClustersL1Seeded)
_HgcalTICLPatternRecognitionL1SeededSequence = cms.Sequence(hltFilteredLayerClustersCLUE3DHighL1Seeded+hltTiclSeedingL1+hltTiclLayerTileProducerL1Seeded+hltTiclTrackstersCLUE3DHighL1Seeded)
_SuperclusteringL1SeededSequence = cms.Sequence(hltParticleFlowClusterHGCalFromTICLL1Seeded+hltParticleFlowSuperClusterHGCalFromTICLL1Seeded)
_HgcalLocalRecoL1SeededSequence = cms.Sequence(hltHgcalDigis+
hltL1TEGammaHGCFilteredCollectionProducer+
hltHgcalDigisL1Seeded+
hltHGCalUncalibRecHitL1Seeded+
hltHGCalRecHitL1Seeded+
hltParticleFlowRecHitHGCL1Seeded+
hltRechitInRegionsHGCAL+
hltHgcalLayerClustersEEL1Seeded+
hltHgcalLayerClustersHSciL1Seeded+
hltHgcalLayerClustersHSiL1Seeded+
hltMergeLayerClustersL1Seeded)

_HgcalTICLPatternRecognitionL1SeededSequence = cms.Sequence(hltFilteredLayerClustersCLUE3DHighL1Seeded+
hltTiclSeedingL1+
hltTiclLayerTileProducerL1Seeded+
hltTiclTrackstersCLUE3DHighL1Seeded)

_SuperclusteringL1SeededSequence = cms.Sequence(hltParticleFlowClusterHGCalFromTICLL1Seeded+
hltParticleFlowSuperClusterHGCalFromTICLL1Seeded)

# The baseline sequence
HLTHgcalTiclPFClusteringForEgammaL1SeededSequence = cms.Sequence(_HgcalLocalRecoL1SeededSequence + _HgcalTICLPatternRecognitionL1SeededSequence + _SuperclusteringL1SeededSequence)
Expand Down
43 changes: 13 additions & 30 deletions ...ation/python/HLT_75e33/sequences/HLTHgcalTiclPFClusteringForEgammaUnseededSequence_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,19 @@
# Barrel layer clusters
from ..modules.hltBarrelLayerClustersEB_cfi import *
from ..modules.hltBarrelLayerClustersHB_cfi import *
_HgcalLocalRecoUnseededSequence = cms.Sequence(hltHgcalDigis+hltHGCalUncalibRecHit+hltHGCalRecHit+hltParticleFlowRecHitHGC+hltHgcalLayerClustersEE+hltHgcalLayerClustersHSci+hltHgcalLayerClustersHSi+hltMergeLayerClusters)
_HgcalTICLPatternRecognitionUnseededSequence = cms.Sequence(hltFilteredLayerClustersCLUE3DHigh+hltTiclSeedingGlobal+hltTiclLayerTileProducer+hltTiclTrackstersCLUE3DHigh)
_SuperclusteringUnseededSequence = cms.Sequence(hltParticleFlowClusterHGCalFromTICLUnseeded+hltParticleFlowSuperClusterHGCalFromTICLUnseeded)
_HgcalLocalRecoUnseededSequence = cms.Sequence(hltHgcalDigis+hltHGCalUncalibRecHit+
hltHGCalRecHit+hltParticleFlowRecHitHGC+
hltHgcalLayerClustersEE+
hltHgcalLayerClustersHSci+
hltHgcalLayerClustersHSi+
hltMergeLayerClusters)

_HgcalTICLPatternRecognitionUnseededSequence = cms.Sequence(hltFilteredLayerClustersCLUE3DHigh+
hltTiclSeedingGlobal+hltTiclLayerTileProducer+
hltTiclTrackstersCLUE3DHigh)

_SuperclusteringUnseededSequence = cms.Sequence(hltParticleFlowClusterHGCalFromTICLUnseeded+
hltParticleFlowSuperClusterHGCalFromTICLUnseeded)

# The baseline sequence
HLTHgcalTiclPFClusteringForEgammaUnseededSequence = cms.Sequence(_HgcalLocalRecoUnseededSequence + _HgcalTICLPatternRecognitionUnseededSequence + _SuperclusteringUnseededSequence)
Expand Down Expand Up @@ -103,30 +113,3 @@
from Configuration.ProcessModifiers.ticl_barrel_cff import ticl_barrel
ticl_barrel.toReplaceWith(_HgcalLocalRecoUnseededSequence, _HgcalLocalRecoUnseededSequence_barrel)

layerClusters = ["hltHgcalLayerClustersEE",
"hltHgcalLayerClustersHSci",
"hltHgcalLayerClustersHSi",
"hltBarrelLayerClustersEB",
"hltBarrelLayerClustersHB"]

time_layerClusters = ["hltHgcalLayerClustersEE:timeLayerCluster",
"hltHgcalLayerClustersHSci:timeLayerCluster",
"hltHgcalLayerClustersHSi:timeLayerCluster",
"hltBarrelLayerClustersEB:timeLayerCluster",
"hltBarrelLayerClustersHB:timeLayerCluster"]

ticl_barrel.toModify(hltMergeLayerClusters, layerClusters=layerClusters, time_layerclusters=time_layerClusters)

layerClusters = ["hltHgCalLayerClustersFromSoAProducer",
"hltHgcalLayerClustersHSci",
"hltHgcalLayerClustersHSi",
"hltBarrelLayerClustersEB",
"hltBarrelLayerClustersHB"]

time_layerClusters = ["hltHgCalLayerClustersFromSoAProducer:timeLayerCluster",
"hltHgcalLayerClustersHSci:timeLayerCluster",
"hltHgcalLayerClustersHSi:timeLayerCluster",
"hltBarrelLayerClustersEB:timeLayerCluster",
"hltBarrelLayerClustersHB:timeLayerCluster"]

(ticl_barrel & alpaka).toModify(hltMergeLayerClusters, layerClusters=layerClusters, time_layerclusters=time_layerClusters)
34 changes: 0 additions & 34 deletions HLTrigger/Configuration/python/HLT_75e33/sequences/HLTTICLLocalRecoSequence_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@
hltHgCalLayerClustersFromSoAProducer+
hltHgcalLayerClustersHSci+
hltHgcalLayerClustersHSi+
hltBarrelLayerClustersEB+
hltBarrelLayerClustersHB+
hltMergeLayerClusters)

from Configuration.ProcessModifiers.alpaka_cff import alpaka
Expand All @@ -54,24 +52,8 @@
hltMergeLayerClusters
)

layerClusters = ["hltHgCalLayerClustersEE",
"hltHgcalLayerClustersHSci",
"hltHgcalLayerClustersHSi",
"hltBarrelLayerClustersEB",
"hltBarrelLayerClustersHB"]

time_layerclusters = ["hltHgCalLayerClustersEE:timeLayerCluster",
"hltHgcalLayerClustersHSci:timeLayerCluster",
"hltHgcalLayerClustersHSi:timeLayerCluster",
"hltBarrelLayerClustersEB:timeLayerCluster",
"hltBarrelLayerClustersHB:timeLayerCluster"]


from Configuration.ProcessModifiers.ticl_barrel_cff import ticl_barrel
ticl_barrel.toReplaceWith(HLTTICLLocalRecoSequence, _HLTTICLLocalRecoSequence_withBarrel)
ticl_barrel.toModify(hltMergeLayerClusters,
layerClusters = layerClusters,
time_layerclusters = time_layerclusters)

_HLTTICLLocalRecoSequence_heterogeneous_withBarrel = cms.Sequence(
hltHGCalUncalibRecHit+
Expand All @@ -88,20 +70,4 @@
hltMergeLayerClusters
)

layerClusters = ["hltHgCalLayerClustersFromSoAProducer",
"hltHgcalLayerClustersHSci",
"hltHgcalLayerClustersHSi",
"hltBarrelLayerClustersEB",
"hltBarrelLayerClustersHB"]

time_layerclusters = ["hltHgCalLayerClustersFromSoAProducer:timeLayerCluster",
"hltHgcalLayerClustersHSci:timeLayerCluster",
"hltHgcalLayerClustersHSi:timeLayerCluster",
"hltBarrelLayerClustersEB:timeLayerCluster",
"hltBarrelLayerClustersHB:timeLayerCluster"]

(ticl_barrel & alpaka).toReplaceWith(HLTTICLLocalRecoSequence, _HLTTICLLocalRecoSequence_heterogeneous_withBarrel)
(ticl_barrel & alpaka).toModify(hltMergeLayerClusters,
layerClusters = layerClusters,
time_layerclusters = time_layerclusters
)