MTD reconstruction: updated MTD track quality BDT

[MartinKlevs]

PR description:

Updated the MTDTrackQualityMVA code with a new and improved BDT model. The new BDT has a few extra input parameters and was trained on a dataset with updated pT cuts. The BDT part of MVATrainingNtuple.cc has been rewritten to be more similar to Validation/MtdValidation/plugins/MtdTracksValidation.cc and to output a few additional track parameters. The training and performance of the BDT is described in this presentation.

The updated BDT code uses a new model file that is is expected to be located at RecoMTD/TimingIDTools/data.

PR validation:

This code has been tested using
runTheMatrix.py -l limited -i all --ibeos

There were no errors from the MTDTrackQualityMVA module, however some of the analysis workflows couldn't access some of the required root files. I'm not sure if that is an issue because it is caused by unavailable datasets and not the code itself. The file read errors contained [3011] No servers are available to read the file.

The BDT was also tested using the 29834.0_TTbar_14TeV+Run4D110PU workflow where everything worked as expected.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48514/45451

[cmsbuild]

A new Pull Request was created by @MartinKlevs for master.

It involves the following packages:

• RecoMTD/TimingIDTools (upgrade, reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test with cms-data/RecoMTD-TimingIDTools#2

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd08ff/47156/summary.html
COMMIT: 509d009
CMSSW: CMSSW_15_1_X_2025-07-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48514/47156/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich fix HLT TICL reconstruction sequences when ticl_barrel is invoked in presence of the alpaka modifier #48509

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd08ff/47156/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dd08ff/47156/git-merge-result

Comparison Summary

Summary:

• You potentially added 19 lines to the logs
• Reco comparison results: 470 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4067201
• DQMHistoTests: Total failures: 782
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4066399
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[fabiocos]

@cms-sw/upgrade-l2 comments?

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/RecoMTD-TimingIDTools#2

[mandrenguyen]

+1