feat: replace testnet 3 with testnet 4 #16426

karliatto · 2025-01-16T15:36:40Z

Description

Replacing default Bitcoin Testnet account from Testnet3 to Testnet4. And adding an information banner to the message system.

TODOs:

Update connect core and popup tests where we use Testnet 3 to use custom backend and add a note to update it to use regtest.

Related Issue

Resolve #14951

karliatto · 2025-01-16T15:37:07Z

suite-common/message-system/config/config.v1.json

+                },
+                "cta": {
+                    "action": "external-link",
+                    "link": "https://trezor.io/learn/a/what-is-trezor-suite-lite#open-chat",


I still need to know the knowledge base article to be here.

Already modified to the right one.

karliatto · 2025-01-16T15:37:43Z

suite-common/message-system/config/config.v1.json

+                "variant": "info",
+                "category": ["banner"],
+                "content": {
+                    "en-GB": "Testnet account has been updated to new Testnet4.",


Maybe more information is needed or the link to the article would be enough ?

I wonder whether it is important to handle testnet update this much gracefully. Isn't testnet something that is unstable by default?

Some people use Testnet for learning about self-custody Bitcoin. So they get confident before they buy some mainnet BTC.
After this change they are going to see empty balance so some message is kind of nice to let them know that it is all right. Anyway the message will appear only to users with Testnet enabled.

github-actions · 2025-01-16T15:40:52Z

🚀 Expo preview is ready!

Project → trezor-suite-preview
Platforms → android, ios
Scheme → trezorsuitelite
Runtime Version → 23
More info

Learn more about 𝝠 Expo Github Action

karliatto · 2025-01-16T16:22:07Z

suite-common/message-system/config/config.v1.json

    "sequence": 74,
    "actions": [
+        {
+            "conditions": [


It requires condition so it display only to users that have Testnet coin enabled.

karliatto · 2025-01-16T16:22:35Z

suite-common/message-system/config/config.v1.json

+            "conditions": [
+                {
+                    "environment": {
+                        "desktop": ">=25.1.2",


This is probably going to be next release. But maybe confirm it when release come.

karliatto · 2025-01-21T09:15:53Z

suite-common/message-system/config/config.v1.json

+                }
+            ],
+            "message": {
+                "id": "2855131c-c871-4fe3-a758-ab7bd92b9934",


I generated this id randomly.

karliatto · 2025-01-21T09:16:36Z

suite-common/message-system/config/config.v1.json

+                },
+                "cta": {
+                    "action": "external-link",
+                    "link": "https://trezor.io/learn/a/bitcoin-testnet",


This article is going to be updated to explain how to get back to Testnet 3.

karliatto · 2025-01-21T09:24:33Z

suite-common/message-system/config/config.v1.json

@@ -1,8 +1,70 @@
 {
    "version": 1,
-    "timestamp": "2024-01-03T00:00:00+00:00",
+    "timestamp": "2025-01-06T00:00:00+00:00",


@matejkriz could you please advise if this message-system "action" is properly defined?

matejkriz · 2025-01-24T09:47:30Z

suite-common/message-system/config/config.v1.json

+                    "action": "external-link",
+                    "link": "https://trezor.io/learn/a/bitcoin-testnet",
+                    "label": {
+                        "en-GB": "Learn how to get back to Testnet 3:",


Too long, "Learn more" would fit better (on desktop it is a button label)

Sure, thanks. Done 46c797f

matejkriz · 2025-01-24T09:49:04Z

suite-common/message-system/config/config.v1.json

+                        {
+                            "tor": true,
+                            "tbtc": true
+                        },
+                        {
+                            "tor": false,
+                            "tbtc": true
+                        }


I think there is no need to specify tor state.

Suggested change

{

"tor": true,

"tbtc": true

},

{

"tor": false,

"tbtc": true

}

{

"tbtc": true

}

And I believe the key is test not tbtc, but not sure if there are some changes.

Sure, thanks. Done 46c797f

karliatto · 2025-01-24T12:09:02Z

I just rebased it since I wanted to get latest state of suite tests and see where are those failing because of this changes.

karliatto · 2025-01-27T17:49:53Z

@matejkriz I applied the changes you suggested and tested the message system locally, picture in the Pull Request description.

Tests are now passing. I think this is ready to go. The article is going to be updated to include more information about how to make Trezor Suite to get back to Testnet 3 if any user wants that.

martykan · 2025-01-27T22:40:53Z

packages/connect-common/files/coins.json

@@ -2636,7 +2680,7 @@
        {
            "blockchain_link": {
                "type": "blockfrost",
-                "url": ["wss://ada1.trezor.io", "wss://ada2.trezor.io"]
+                "url": ["wss://trezor-cardano-mainnet.blockfrost.io"]


We don't want these changes, seems like these were recently updated in Suite repo but not in FW repo
c6d420c

I see, I just talked to @tomasklim and they were modified manually. I will ignore the changes, and just add the changes I need for this. Soon trezor-common will be the source of truth trezor/trezor-firmware#4530

Replacing testnet 3 with testnet 4 as default Bitcoin Testnet.

karliatto commented Jan 16, 2025

View reviewed changes

karliatto force-pushed the feat/replace-testnet3-with-testnet-4 branch from b5fe4b5 to 70cfb21 Compare January 16, 2025 15:48

karliatto commented Jan 16, 2025

View reviewed changes

karliatto force-pushed the feat/replace-testnet3-with-testnet-4 branch 2 times, most recently from eb44fd2 to 276733c Compare January 21, 2025 09:11

karliatto commented Jan 21, 2025

View reviewed changes

karliatto force-pushed the feat/replace-testnet3-with-testnet-4 branch from 276733c to e8169bb Compare January 21, 2025 09:23

karliatto commented Jan 21, 2025

View reviewed changes

matejkriz reviewed Jan 24, 2025

View reviewed changes

karliatto force-pushed the feat/replace-testnet3-with-testnet-4 branch 2 times, most recently from 9f2cfce to ac8379f Compare January 24, 2025 12:08

karliatto mentioned this pull request Jan 24, 2025

wip #15961

Closed

karliatto force-pushed the feat/replace-testnet3-with-testnet-4 branch 4 times, most recently from a6a4604 to 8012fc7 Compare January 27, 2025 15:22

karliatto marked this pull request as ready for review January 27, 2025 17:11

karliatto requested review from tomasklim, martykan, szymonlesisz, marekrjpolak and vdovhanych as code owners January 27, 2025 17:11

karliatto changed the title ~~WIP: Feat/replace testnet3 with testnet 4~~ feat/eplace testnet3 with testnet 4 Jan 27, 2025

karliatto changed the title ~~feat/eplace testnet3 with testnet 4~~ feat: replace testnet3 with testnet 4 Jan 27, 2025

karliatto changed the title ~~feat: replace testnet3 with testnet 4~~ feat: replace testnet 3 with testnet 4 Jan 27, 2025

martykan reviewed Jan 27, 2025

View reviewed changes

karliatto added 3 commits January 28, 2025 08:40

chore(trezor-common): uptate coins.json and coins-eth.json

94b5ea0

Replacing testnet 3 with testnet 4 as default Bitcoin Testnet.

chore(message-system): add Testnet4 warning

e80d520

ci(github): change input name to disable_cache_tx

6b1cd9f

karliatto force-pushed the feat/replace-testnet3-with-testnet-4 branch from e10d19e to 8fc6481 Compare January 28, 2025 08:40

test(connect): adjust unit test

d64b444

karliatto force-pushed the feat/replace-testnet3-with-testnet-4 branch from 8fc6481 to d64b444 Compare January 28, 2025 09:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: replace testnet 3 with testnet 4 #16426

feat: replace testnet 3 with testnet 4 #16426

karliatto commented Jan 16, 2025 •

edited

Loading

karliatto Jan 16, 2025

karliatto Jan 16, 2025

karliatto Jan 16, 2025

mroz22 Jan 20, 2025

karliatto Jan 20, 2025

github-actions bot commented Jan 16, 2025 •

edited

Loading

karliatto Jan 16, 2025

karliatto Jan 16, 2025

karliatto Jan 21, 2025

karliatto Jan 21, 2025

karliatto Jan 21, 2025

matejkriz Jan 24, 2025

karliatto Jan 24, 2025

matejkriz Jan 24, 2025

matejkriz Jan 24, 2025

karliatto Jan 24, 2025

karliatto commented Jan 24, 2025

karliatto commented Jan 27, 2025 •

edited

Loading

martykan Jan 27, 2025

karliatto Jan 28, 2025

feat: replace testnet 3 with testnet 4 #16426

Are you sure you want to change the base?

feat: replace testnet 3 with testnet 4 #16426

Conversation

karliatto commented Jan 16, 2025 • edited Loading

Description

Related Issue

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karliatto commented Jan 24, 2025

karliatto commented Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

karliatto commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

karliatto commented Jan 27, 2025 •

edited

Loading