Skip to content

Commit

Permalink
ci(github): change input name to disable_cache_tx
Browse files Browse the repository at this point in the history
  • Loading branch information
karliatto committed Jan 24, 2025
1 parent 3461e65 commit ac8379f
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 15 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/template-connect-test-params.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ on:
type: "boolean"
required: false
default: false
cache_tx:
description: "Cache transactions"
# After migrating from testnet 3 to testnet 4 using `disable_cache_tx=true` should be required for tests where tx are used.
disable_cache_tx:
description: "Disable Cache transactions (when `true` tests don't use cache for transactions)"
type: "string"
required: false
default: false
Expand Down Expand Up @@ -89,7 +90,7 @@ jobs:
- if: ${{ inputs.testEnv == 'node' }}
run: yarn workspaces focus @trezor/connect

- if: ${{ inputs.cache_tx == 'true' }}
- if: ${{ inputs.disable_cache_tx == 'true' }}
run: echo "ADDITIONAL_ARGS=-c" >> "$GITHUB_ENV"
- if: ${{ inputs.testFirmwareModel }}
run: echo "ADDITIONAL_ARGS=$ADDITIONAL_ARGS -m ${{ inputs.testFirmwareModel }}" >> "$GITHUB_ENV"
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/test-connect.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,23 +80,23 @@ jobs:

- name: Set daily matrix
id: set-matrix-daily
run: echo "dailyMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=2-latest --env=all --groups=api,api-flaky --cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT
run: echo "dailyMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=2-latest --env=all --groups=api,api-flaky --disable_cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT

- name: Set all firmwares matrix
id: set-matrix-all-firmwares
run: echo "allFwsMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=all --env=all --groups=all --cache_tx=false --transport=2.0.33)" >> $GITHUB_OUTPUT
run: echo "allFwsMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=all --env=all --groups=all --disable_cache_tx=false --transport=2.0.33)" >> $GITHUB_OUTPUT

- name: Set other devices matrix
id: set-matrix-other-devices
run: echo "otherDevicesMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=all --firmware=2-main --env=node --groups=api --cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT
run: echo "otherDevicesMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=all --firmware=2-main --env=node --groups=api --disable_cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT

- name: Set all transports matrix
id: set-matrix-all-transports
run: echo "allTransportsMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=2-latest --env=node --groups=api --cache_tx=true --transport=all)" >> $GITHUB_OUTPUT
run: echo "allTransportsMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=2-latest --env=node --groups=api --disable_cache_tx=true --transport=all)" >> $GITHUB_OUTPUT

- name: Set trezor model one matrix
id: set-matrix-model-one
run: echo "modelOneMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T1B1 --firmware=1-latest --env=node --groups=api --cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT
run: echo "modelOneMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T1B1 --firmware=1-latest --env=node --groups=api --disable_cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT

PR-check:
needs: [build, set-matrix]
Expand All @@ -108,7 +108,7 @@ jobs:
includeFilter: ${{ matrix.groups.includeFilter }}
testsFirmware: ${{ matrix.firmware }}
testDescription: ${{ matrix.env }}-${{ matrix.groups.pattern }}-${{ matrix.groups.name }}
cache_tx: ${{ matrix.cache_tx }}
disable_cache_tx: ${{ matrix.disable_cache_tx }}
transport: ${{ matrix.transport }}
testEnv: ${{ matrix.env }}
testFirmwareModel: ${{ matrix.model }}
Expand All @@ -119,14 +119,14 @@ jobs:
randomized-order:
needs: [build, set-matrix]
name: randomized ${{ matrix.key }}
if: (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') && github.repository == 'trezor/trezor-suite'
# if: (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') && github.repository == 'trezor/trezor-suite'
uses: ./.github/workflows/template-connect-test-params.yml
with:
testPattern: ${{ matrix.groups.pattern }}
includeFilter: ${{ matrix.groups.includeFilter }}
testsFirmware: ${{ matrix.firmware }}
testDescription: ${{ matrix.env }}-${{ matrix.groups.pattern }}-${{ matrix.groups.name }}
cache_tx: ${{ matrix.cache_tx }}
disable_cache_tx: ${{ matrix.disable_cache_tx }}
transport: ${{ matrix.transport }}
testEnv: ${{ matrix.env }}
testFirmwareModel: ${{ matrix.model }}
Expand All @@ -145,7 +145,7 @@ jobs:
includeFilter: ${{ matrix.groups.includeFilter }}
testsFirmware: ${{ matrix.firmware }}
testDescription: ${{ matrix.firmware }}-${{ matrix.groups.pattern }}-${{ matrix.groups.name }}-${{ matrix.env }}
cache_tx: ${{ matrix.cache_tx }}
disable_cache_tx: ${{ matrix.disable_cache_tx }}
transport: ${{ matrix.transport }}
testEnv: ${{ matrix.env }}
testFirmwareModel: ${{ matrix.model }}
Expand All @@ -163,7 +163,7 @@ jobs:
includeFilter: ${{ matrix.groups.includeFilter }}
testsFirmware: ${{ matrix.firmware }}
testDescription: ${{ matrix.model }}-${{ matrix.firmware }}
cache_tx: ${{ matrix.cache_tx }}
disable_cache_tx: ${{ matrix.disable_cache_tx }}
transport: ${{ matrix.transport }}
testEnv: ${{ matrix.env }}
testFirmwareModel: ${{ matrix.model }}
Expand All @@ -181,7 +181,7 @@ jobs:
includeFilter: ${{ matrix.groups.includeFilter }}
testsFirmware: ${{ matrix.firmware }}
testDescription: ${{ matrix.transport }}
cache_tx: ${{ matrix.cache_tx }}
disable_cache_tx: ${{ matrix.disable_cache_tx }}
transport: ${{ matrix.transport }}
testEnv: ${{ matrix.env }}
testFirmwareModel: ${{ matrix.model }}
Expand All @@ -199,7 +199,7 @@ jobs:
includeFilter: ${{ matrix.groups.includeFilter }}
testsFirmware: ${{ matrix.firmware }}
testDescription: ${{ matrix.model }}-${{ matrix.firmware }}
cache_tx: ${{ matrix.cache_tx }}
disable_cache_tx: ${{ matrix.disable_cache_tx }}
transport: ${{ matrix.transport }}
testEnv: ${{ matrix.env }}
testFirmwareModel: ${{ matrix.model }}
Expand Down

0 comments on commit ac8379f

Please sign in to comment.