-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace testnet 3 with testnet 4 #16426
Changes from all commits
e294382
52ba9c3
bc2a012
d37668c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
+4 −4 | defs/README.md | |
+1 −1 | defs/bitcoin/bitcoin_testnet.json | |
+44 −0 | defs/bitcoin/ecash.json | |
+ − | defs/bitcoin/ecash.png | |
+5 −6 | defs/blockchain_link.json | |
+1 −1 | defs/ethereum/networks.json | |
+1 −1 | defs/ethereum/released-definitions-timestamp.txt | |
+125 −5 | defs/support.json | |
+27 −3 | models.json | |
+46 −0 | protob/messages-benchmark.proto | |
+12 −7 | protob/messages-bitcoin.proto | |
+2 −2 | protob/messages-common.proto | |
+2 −2 | protob/messages-crypto.proto | |
+29 −9 | protob/messages-debug.proto | |
+0 −1 | protob/messages-ethereum.proto | |
+36 −6 | protob/messages-management.proto | |
+3 −3 | protob/messages-monero.proto | |
+39 −0 | protob/messages-thp.proto | |
+13 −59 | protob/messages.proto | |
+66 −0 | protob/options.proto | |
+2 −1 | protob/pb2py | |
+81 −0 | releases.json | |
+0 −150 | tests/fixtures/cardano/sign_tx.show_details.json | |
+12 −28 | tools/coin_info.py | |
+13 −6 | tools/cointool.py | |
+5 −0 | tools/requirements.txt | |
+24 −28 | tools/support.py |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,65 @@ | ||
{ | ||
"version": 1, | ||
"timestamp": "2025-01-28T00:00:00+00:00", | ||
"sequence": 76, | ||
"sequence": 77, | ||
"actions": [ | ||
{ | ||
"conditions": [ | ||
{ | ||
"environment": { | ||
"desktop": ">=25.1.2", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is probably going to be next release. But maybe confirm it when release come. |
||
"mobile": "!", | ||
"web": "*" | ||
}, | ||
"settings": [ | ||
{ | ||
"test": true | ||
} | ||
] | ||
} | ||
], | ||
"message": { | ||
"id": "2855131c-c871-4fe3-a758-ab7bd92b9934", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I generated this id randomly. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it uuid4? I usually generate it here https://www.uuidgenerator.net/version4 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I did not use that tool but the format is the same. |
||
"priority": 90, | ||
"dismissible": true, | ||
"variant": "info", | ||
"category": ["banner"], | ||
"content": { | ||
"en-GB": "Testnet account has been updated to new Testnet 4.", | ||
"en": "Testnet account has been updated to new Testnet 4.", | ||
"es": "Testnet account has been updated to new Testnet 4.", | ||
"cs": "Testnet account has been updated to new Testnet 4.", | ||
"ru": "Testnet account has been updated to new Testnet 4.", | ||
"ja": "Testnet account has been updated to new Testnet 4.", | ||
"hu": "Testnet account has been updated to new Testnet 4.", | ||
"it": "Testnet account has been updated to new Testnet 4.", | ||
"fr": "Testnet account has been updated to new Testnet 4.", | ||
"de": "Testnet account has been updated to new Testnet 4.", | ||
"tr": "Testnet account has been updated to new Testnet 4.", | ||
"pt": "Testnet account has been updated to new Testnet 4.", | ||
"uk": "Testnet account has been updated to new Testnet 4.." | ||
}, | ||
"cta": { | ||
"action": "external-link", | ||
"link": "https://trezor.io/learn/a/bitcoin-testnet#testnet4", | ||
"label": { | ||
"en-GB": "Learn More", | ||
"en": "Learn More", | ||
"es": "Learn More", | ||
"cs": "Learn More", | ||
"ru": "Learn More", | ||
"ja": "Learn More", | ||
"hu": "Learn More", | ||
"it": "Learn More", | ||
"fr": "Learn More", | ||
"de": "Learn More", | ||
"tr": "Learn More", | ||
"pt": "Learn More", | ||
"uk": "Learn More" | ||
} | ||
} | ||
} | ||
}, | ||
{ | ||
"conditions": [ | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It requires condition so it display only to users that have Testnet coin enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to bump the sequence number, rebase to develop should solve this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased to develop and the new number is
sequence": 76,
should I bump it to 77?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the new sequence needs to be higher than the existing one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Done https://github.com/trezor/trezor-suite/pull/16426/files#diff-23b61cc32ee43e487b64d10bb4c26281a0cbdd218223919c5dd14523cdefc687R4