Skip to content

Commit 9f2cfce

Browse files
committed
ci(github): change input name to disable_cache_tx
1 parent 46c797f commit 9f2cfce

File tree

2 files changed

+16
-15
lines changed

2 files changed

+16
-15
lines changed

.github/workflows/template-connect-test-params.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,9 @@ on:
2929
type: "boolean"
3030
required: false
3131
default: false
32-
cache_tx:
33-
description: "Cache transactions"
32+
# After migrating from testnet 3 to testnet 4 using `disable_cache_tx=true` should be required for tests where tx are used.
33+
disable_cache_tx:
34+
description: "Disable Cache transactions (when `true` tests don't use cache for transactions)"
3435
type: "string"
3536
required: false
3637
default: false
@@ -89,7 +90,7 @@ jobs:
8990
- if: ${{ inputs.testEnv == 'node' }}
9091
run: yarn workspaces focus @trezor/connect
9192

92-
- if: ${{ inputs.cache_tx == 'true' }}
93+
- if: ${{ inputs.disable_cache_tx == 'true' }}
9394
run: echo "ADDITIONAL_ARGS=-c" >> "$GITHUB_ENV"
9495
- if: ${{ inputs.testFirmwareModel }}
9596
run: echo "ADDITIONAL_ARGS=$ADDITIONAL_ARGS -m ${{ inputs.testFirmwareModel }}" >> "$GITHUB_ENV"

.github/workflows/test-connect.yml

+12-12
Original file line numberDiff line numberDiff line change
@@ -80,23 +80,23 @@ jobs:
8080

8181
- name: Set daily matrix
8282
id: set-matrix-daily
83-
run: echo "dailyMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=2-latest --env=all --groups=api,api-flaky --cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT
83+
run: echo "dailyMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=2-latest --env=all --groups=api,api-flaky --disable_cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT
8484

8585
- name: Set all firmwares matrix
8686
id: set-matrix-all-firmwares
87-
run: echo "allFwsMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=all --env=all --groups=all --cache_tx=false --transport=2.0.33)" >> $GITHUB_OUTPUT
87+
run: echo "allFwsMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=all --env=all --groups=all --disable_cache_tx=false --transport=2.0.33)" >> $GITHUB_OUTPUT
8888

8989
- name: Set other devices matrix
9090
id: set-matrix-other-devices
91-
run: echo "otherDevicesMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=all --firmware=2-main --env=node --groups=api --cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT
91+
run: echo "otherDevicesMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=all --firmware=2-main --env=node --groups=api --disable_cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT
9292

9393
- name: Set all transports matrix
9494
id: set-matrix-all-transports
95-
run: echo "allTransportsMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=2-latest --env=node --groups=api --cache_tx=true --transport=all)" >> $GITHUB_OUTPUT
95+
run: echo "allTransportsMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T2T1 --firmware=2-latest --env=node --groups=api --disable_cache_tx=true --transport=all)" >> $GITHUB_OUTPUT
9696

9797
- name: Set trezor model one matrix
9898
id: set-matrix-model-one
99-
run: echo "modelOneMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T1B1 --firmware=1-latest --env=node --groups=api --cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT
99+
run: echo "modelOneMatrix=$(node ./scripts/ci/connect-test-matrix-generator.js --model=T1B1 --firmware=1-latest --env=node --groups=api --disable_cache_tx=true --transport=2.0.33)" >> $GITHUB_OUTPUT
100100

101101
PR-check:
102102
needs: [build, set-matrix]
@@ -108,7 +108,7 @@ jobs:
108108
includeFilter: ${{ matrix.groups.includeFilter }}
109109
testsFirmware: ${{ matrix.firmware }}
110110
testDescription: ${{ matrix.env }}-${{ matrix.groups.pattern }}-${{ matrix.groups.name }}
111-
cache_tx: ${{ matrix.cache_tx }}
111+
disable_cache_tx: ${{ matrix.disable_cache_tx }}
112112
transport: ${{ matrix.transport }}
113113
testEnv: ${{ matrix.env }}
114114
testFirmwareModel: ${{ matrix.model }}
@@ -119,14 +119,14 @@ jobs:
119119
randomized-order:
120120
needs: [build, set-matrix]
121121
name: randomized ${{ matrix.key }}
122-
if: (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') && github.repository == 'trezor/trezor-suite'
122+
# if: (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') && github.repository == 'trezor/trezor-suite'
123123
uses: ./.github/workflows/template-connect-test-params.yml
124124
with:
125125
testPattern: ${{ matrix.groups.pattern }}
126126
includeFilter: ${{ matrix.groups.includeFilter }}
127127
testsFirmware: ${{ matrix.firmware }}
128128
testDescription: ${{ matrix.env }}-${{ matrix.groups.pattern }}-${{ matrix.groups.name }}
129-
cache_tx: ${{ matrix.cache_tx }}
129+
disable_cache_tx: ${{ matrix.disable_cache_tx }}
130130
transport: ${{ matrix.transport }}
131131
testEnv: ${{ matrix.env }}
132132
testFirmwareModel: ${{ matrix.model }}
@@ -145,7 +145,7 @@ jobs:
145145
includeFilter: ${{ matrix.groups.includeFilter }}
146146
testsFirmware: ${{ matrix.firmware }}
147147
testDescription: ${{ matrix.firmware }}-${{ matrix.groups.pattern }}-${{ matrix.groups.name }}-${{ matrix.env }}
148-
cache_tx: ${{ matrix.cache_tx }}
148+
disable_cache_tx: ${{ matrix.disable_cache_tx }}
149149
transport: ${{ matrix.transport }}
150150
testEnv: ${{ matrix.env }}
151151
testFirmwareModel: ${{ matrix.model }}
@@ -163,7 +163,7 @@ jobs:
163163
includeFilter: ${{ matrix.groups.includeFilter }}
164164
testsFirmware: ${{ matrix.firmware }}
165165
testDescription: ${{ matrix.model }}-${{ matrix.firmware }}
166-
cache_tx: ${{ matrix.cache_tx }}
166+
disable_cache_tx: ${{ matrix.disable_cache_tx }}
167167
transport: ${{ matrix.transport }}
168168
testEnv: ${{ matrix.env }}
169169
testFirmwareModel: ${{ matrix.model }}
@@ -181,7 +181,7 @@ jobs:
181181
includeFilter: ${{ matrix.groups.includeFilter }}
182182
testsFirmware: ${{ matrix.firmware }}
183183
testDescription: ${{ matrix.transport }}
184-
cache_tx: ${{ matrix.cache_tx }}
184+
disable_cache_tx: ${{ matrix.disable_cache_tx }}
185185
transport: ${{ matrix.transport }}
186186
testEnv: ${{ matrix.env }}
187187
testFirmwareModel: ${{ matrix.model }}
@@ -199,7 +199,7 @@ jobs:
199199
includeFilter: ${{ matrix.groups.includeFilter }}
200200
testsFirmware: ${{ matrix.firmware }}
201201
testDescription: ${{ matrix.model }}-${{ matrix.firmware }}
202-
cache_tx: ${{ matrix.cache_tx }}
202+
disable_cache_tx: ${{ matrix.disable_cache_tx }}
203203
transport: ${{ matrix.transport }}
204204
testEnv: ${{ matrix.env }}
205205
testFirmwareModel: ${{ matrix.model }}

0 commit comments

Comments
 (0)