-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEXT: Skeleton v3 Migration CLI #2972
base: next
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Hugos68 is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hugos68 everything is looking great. Just a few bits of feedback so far.
|
||
const TAILWIND_COMPONENT_REGEXES = [ | ||
{ | ||
find: /\bcard\b(?!.*bg-)/g, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a heads up - we need to ensure we don't just blindly insert the background class for .card
migrations. It should only be added if no existing bg-
class is found in the class list.
Imagine a scenario like this in a v2 project:
<div class="card bg-primary-400-500">...</div>
The card already has a background established, but the migration would insert our additional (and undesired) background class:
<div class="card bg-surface-100-900-token bg-primary-500 dark:bg-primary-500">...</div>
In this case, no migration should have occurred for this instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't migrate that then, there is no way to detect wether bg-
is present or not as it can be added in a million ways.
For example class="card {bgClasses}"
, I'd say we skip this and/or migrate the card
class without a background by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential solution from Discord. Append folk's global stylesheet and add the following:
/* SKETON CLI - appended this to ensure backwards combability. Please remove and update your `.card` usage. */
.card { @apply bg-surface-100-900; }
Just FYI, a gotcha with the global stylesheet is the extension varies in my experience. I've seen several options:
app.postcss
app.pcss
app.css
@Hugos68 I'm going to be going through and update all project dependencies for the Skeleton monorepo per: Can you please make sure the migration CLI is updated to support Node 22 - assuming it's not already! Otherwise disregard this message. |
Linked Issue
No issue (perhaps we should create one)
Description
Introduces the official Skeleton CLI that currently features:
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test