Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next branch dependency updates for all projects #3021

Closed
endigo9740 opened this issue Dec 4, 2024 · 2 comments
Closed

Next branch dependency updates for all projects #3021

endigo9740 opened this issue Dec 4, 2024 · 2 comments
Assignees
Labels
administration Items related to the project but outside the code.
Milestone

Comments

@endigo9740
Copy link
Contributor

endigo9740 commented Dec 4, 2024

We should go ahead and update all project dependencies and check for regressions.

This will include a notable update to Astro 5, which now utilizes Vite 6:
https://astro.build/blog/astro-5/

As well as migrating all projects to a minimum of Node 22, to satisfy and upcoming change on Vercel:

Screenshot 2024-12-04 at 1 02 49 PM

Once changes changes are pushed, all contributors should be encouraged to update to use Node 22 on their local machines.

@endigo9740 endigo9740 self-assigned this Dec 4, 2024
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Dec 4, 2024
@endigo9740 endigo9740 added the administration Items related to the project but outside the code. label Dec 4, 2024
@endigo9740
Copy link
Contributor Author

endigo9740 commented Dec 4, 2024

@Hugos68 FYI, it looks like there was a major release to Astro and/or @astro/mdx that is triggering two issues and may prevent us from updating to Astro v5 for now...

First, the getCollections() method in Astro is no longer returning a slug per item. If you hover item it still shows this as a required value, but this is missing when you actually log the value. This is affecting a number of components in our app, including:

  • NavGrid.astro
  • TableCookbook.astro
  • Navigation.astro

We can substitute item.slug with item.filePath? as a quick fix fix.

Screenshot 2024-12-04 at 1 51 29 PM

Second, when switching to any page that has MDX rendered, there is a very obvious flash of styled content. However if you switch to a page that does not include MDX (ex: /news) this does not occur. I'm guessing this is either related to some pre-rendering or some new issues between the layout & rendered MDX.

Kapture.2024-12-04.at.13.53.49.mp4

I'd welcome your support in troubleshooting these if possible. The PR is here if you would like to test directly:

Steps to reproduce:

  • Pull down the PR
  • Point your terminal at the v3 Astro docs project
  • Run pnpm update -i -L to update all packages and package.json
  • Run the project and you'll be met with the slug issue (see the fix above)
  • Transition between the pages and you'll see the unstyled flashing issue

@endigo9740
Copy link
Contributor Author

endigo9740 commented Dec 4, 2024

FYI I've pushed some additional changes:

  • Updated the Vercel apps for the v3 docs and v3 theme generator projects to utilized Node 22.
  • Pushed additional deps updates for the React package that was missing prior (pnpm outdated didn't show these for some reason).
  • Resolved new linting issues that popped up in the React package related to the use of the Context API feature in React - they seem to require these to be scaffolded outside the component files now.

Unfortunately I noticed we're also having issues with the current PR's CI checks...

The "check" step is showing this Astro-check error, even though Astro has yet to be updated. For some reason I cannot replicate this locally. It's like it's running a version head of my local instance - even though I specifically avoided updating the Astro project.

Screenshot 2024-12-04 at 4 51 35 PM

Additionally the "lint" step is failing as well. Best I can tell it seems to be running eslint v9 even though the monorepo root's package.json specifies eslint v8. The v9 updates has some major breaking changes, which do not seem trivial to implement so we're purposely trying to stick with v8 for now.

No idea why it's running v9, my local instance shows the same with pnpm lint, but the package.json clearly indicates the following:

"eslint": "^8.57.1",

Screenshot 2024-12-04 at 4 58 41 PM

Screenshot 2024-12-04 at 4 52 44 PM

Similarly the "test" step is failing. It seems to indicate an issue with Zag within one of the Svelte components. Once again, I can't seem to replicate this when running pnpm test locally from the monorepo root.

Screenshot 2024-12-04 at 4 54 57 PM

I'm feeling frustrated with so many breaking issues, so I'm just going to pause here for the day. If anyone has any ideas on these I'm all ears.

@endigo9740 endigo9740 pinned this issue Dec 4, 2024
@endigo9740 endigo9740 unpinned this issue Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
administration Items related to the project but outside the code.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant