Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(next): update dependencies #3023

Merged
merged 14 commits into from
Dec 6, 2024
Merged

chore(next): update dependencies #3023

merged 14 commits into from
Dec 6, 2024

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Dec 5, 2024

Linked Issue

Closes #3021

NOTE: Alternative to #3022

Description

Updates dependencies for the following projects:

  • Sites
    • v3 docs - next.skeleton.dev
    • v3 Theme Generator - themes.skeleton.dev
  • Packages
    • v3 Core Package
    • v3 React Package
    • v3 Svelte Package
    • Necroparser
    • vite-plugin-tw-plugin-watcher
    • v3 Migration CLI (reminder sent on PR)

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, chore/, bugfix/
  • Skeleton v3 contributions must target the next branch (NEVER dev or master)
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changsets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR review for review.

Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: fd08e3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ❌ Failed (Inspect) 💬 Add feedback Dec 6, 2024 6:32pm
skeleton-next 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 6:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
skeleton-themes ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 6:32pm

@endigo9740
Copy link
Contributor

endigo9740 commented Dec 5, 2024

@Hugos68 @AdrianGonz97 I'd appreciate a review of all current changes. A few notable updates today:

  1. I resolved the Astro v5 "flashbang" issue by wrapping the MDX route with <LayoutRoot>
  2. I've updated all instances of getCollections to use filePath and entry.id from meta.mdx -> meta
  3. I've updated the Svelte component package to use Vitest v3 beta. This is the only version that supports Vite 6.

Note that I did NOT refactor the React components using the Context API to have the Context set outside the component files. This looks to be a new linting rule added in a major release, which we're not using yet. We can cross that road when we come to this. The linting error is very clear about the change required.

I've also reached out the the Skeleton team and contributor community to do some manual regression testing against the doc site. See that in the #skeleton-next channel on Discord.

@endigo9740 endigo9740 self-requested a review December 5, 2024 19:55
Copy link
Member

@TazorDE TazorDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything out of place
lgtm

@endigo9740 endigo9740 merged commit 996b63e into next Dec 6, 2024
7 of 8 checks passed
@endigo9740 endigo9740 deleted the chore/bump-deps branch December 6, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants