OCPBUGS-65544: MCO-1886: add the missing service to the expose ports 22623 and 22624 #5371
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@aabughosh: This pull request references MCO-1886 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@aabughosh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Seems like this is passing CI. For safety: /payload 4.21 nightly blocking As I understand it ClusterIP will expose this as a cluster-internal service, so the security and access of the port should be unchanged. This will also not affect any existing workflows since new nodes can continue using host network directly. Is that understanding correct? |
|
@yuqi-zhang: trigger 13 job(s) of type blocking for the nightly release of OCP 4.21
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/52b3a7b0-b51d-11f0-9ba0-c565ac040e58-0 |
|
@yuqi-zhang Yes, that’s correct. We’re keeping the machine-config-server Service as ClusterIP. The server pods already run with hostNetwork: true, so ports 22623/22624 are exposed on the node IPs. The ClusterIP only provides an in-cluster virtual IP and doesn’t change the external exposure or access behavior |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
/lgtm
Thanks for the explanation. I think we should be safe to progress here given green CI.
@aabughosh do you need additional verification? Otherwise feel free to mark this with /verified by ...
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aabughosh, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/verified @yuqi-zhang |
|
@aabughosh: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by @yuqi-zhang |
openshift-ci-robot
added
the
verified
|
@aabughosh: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-bot
bot
merged commit 747fddc
into
openshift:main
|
/cherry-pick release-4.20 |
|
@aabughosh: new pull request created: #5393 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
yuqi-zhang
changed the title
|
@aabughosh: Jira Issue OCPBUGS-65544: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-65544 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.19 |
|
@aabughosh: new pull request created: #5473 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
regarding to this bug https://issues.redhat.com/browse/MCO-1886
- What I did
added a new ClusterIP Service machine-config-server in openshift-machine-config-operator.
Exposes TCP ports 22623 (https) and 22624 (http) used by the Machine Config Server.