Skip to content

[release-4.20] OCPBUGS-65545, OCPBUGS-67007: cherry pick to few fixes that needed for missing services and configuration #5480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Dec 11, 2025
Merged

[release-4.20] OCPBUGS-65545, OCPBUGS-67007: cherry pick to few fixes that needed for missing services and configuration #5480

openshift-merge-bot merged 3 commits into from
Dec 11, 2025

Conversation

@aabughosh
Copy link
Contributor

@aabughosh aabughosh commented Dec 10, 2025

cherry pick to #5463
and
#5456

@aabughosh
Add hostIP 127.0.0.1 to machine-config-daemon port 8798
45e456a 
- Added `hostIP: 127.0.0.1` to the containerPort 8798 to explicitly indicate
  that the health port is only bound to localhost.
- Matches the existing behavior in logs:
    "Starting health listener on 127.0.0.1:8798"
  and address config: Addr: "127.0.0.1:8798"
- This is informational and clarifies that this port is not externally exposed.
@aabughosh
add a relevant svc to the crio port
939701a
@aabughosh
add missing ports in contaiterport on the daemoset
2499bc2
@aabughosh aabughosh changed the title a cherry pick to few fixes that needed for missing services and configuration [release-4.20 cherry pick to few fixes that needed for missing services and configuration Dec 10, 2025
@aabughosh aabughosh changed the title [release-4.20 cherry pick to few fixes that needed for missing services and configuration [release-4.20] cherry pick to few fixes that needed for missing services and configuration Dec 10, 2025
@yuqi-zhang yuqi-zhang mentioned this pull request Dec 10, 2025
Closed
@yuqi-zhang yuqi-zhang changed the title [release-4.20] cherry pick to few fixes that needed for missing services and configuration [release-4.20] OCPBUGS-65545, OCPBUGS-67007: cherry pick to few fixes that needed for missing services and configuration Dec 10, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 10, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025

@aabughosh: This pull request references Jira Issue OCPBUGS-65545, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-67007, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-66314 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-66314 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

cherry pick to #5463
and
#5456

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yuqi-zhang yuqi-zhang mentioned this pull request Dec 10, 2025
Closed
yuqi-zhang
yuqi-zhang approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

Should be no different on this version. This looks to be the consolidated PR of #5371 , #5456 and #5463 . We will try to backport this as one PR to 4.20 and prior

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 10, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aabughosh, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2025
@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Dec 10, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 10, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 10, 2025

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-65545, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-65544 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-65544 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

This pull request references Jira Issue OCPBUGS-67007, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-66314 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-66314 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr December 10, 2025 21:44
@aabughosh
Copy link
Contributor Author

aabughosh commented Dec 11, 2025

/verified by @aabughosh

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2025

@aabughosh: This PR has been marked as verified by @aabughosh.

In response to this:

/verified by @aabughosh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aabughosh
Copy link
Contributor Author

aabughosh commented Dec 11, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

@aabughosh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit 2499bc2 link false /test bootstrap-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3eb8e48 into openshift:release-4.20 Dec 11, 2025
14 of 15 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2025

@aabughosh: Jira Issue Verification Checks: Jira Issue OCPBUGS-65545
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65545 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Jira Issue Verification Checks: Jira Issue OCPBUGS-67007
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-67007 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

cherry pick to #5463
and
#5456

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@yuqi-zhang yuqi-zhang mentioned this pull request Dec 11, 2025
Closed
@yuqi-zhang
Copy link
Contributor

yuqi-zhang commented Dec 12, 2025

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 12, 2025

@yuqi-zhang: new pull request created: #5490

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@pablintino pablintino Awaiting requested review from pablintino

@sergiordlr sergiordlr Awaiting requested review from sergiordlr

Assignees

@rbbratta rbbratta

@eurijon eurijon

@zhaozhanqi zhaozhanqi

@lyman9966 lyman9966

@anuragthehatter anuragthehatter

@sergiordlr sergiordlr

@imatza-rh imatza-rh

@rioliu-rh rioliu-rh

@mhanss mhanss

@ptalgulk01 ptalgulk01

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.