-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
@Ignore AtomicFileWriterPerfTest #3797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@Ignore AtomicFileWriterPerfTest #3797
Conversation
Wadeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure such approach is really good for the long run.
I tend to agree. I guess I could just delete the test. I wanted to avoid this, but given the perf of the storage, there's probably no good way out. Or at some point introduce a profile for such flakes/things that require some normal environment. (if you check the comment around the test, you'll see that these perfs are absolutely horrible, it's like 3 times slower than an old 5400 RPM hard-disk).... |
jglick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just @Ignore this test so we are not bothered with it in CI.
c103019 to
b9c9b2b
Compare
| * Was analyzed in https://github.com/jenkinsci/jenkins/pull/3788, to summarize the performances in ci.jenkins.io are | ||
| * wildly varying, to say the least, between 2.5 seconds, and 1 min 9 seconds! | ||
| * | ||
| * So bumping this here to 70 seconds, so we keep being able to catch huge regressions if someone touches the Jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obsolete comment
|
Superseded by #3799 |
No JIRA nor changelog, trivial change. Causing recent build flakiness for no obvious reason (this test was added 1+ year ago).
Proposed changelog entries
Submitter checklist
- [ ] JIRA issue is well described* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)- [ ] Appropriate autotests or explanation to why this change has no tests- [ ] For dependency updates: links to external changelogs and, if possible, full diffsDesired reviewers