Skip to content

[DO NOT MERGE] Only run the AtomicFileWriterPerfTest #3788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
batmat wants to merge 9 commits into from
Closed

[DO NOT MERGE] Only run the AtomicFileWriterPerfTest #3788

batmat wants to merge 9 commits into from

Conversation

@batmat
Copy link
Member

@batmat batmat commented Dec 4, 2018

Analysis PR, please ignore. Thanks

@batmat batmat added the work-in-progress The PR is under active development, not ready to the final review label Dec 4, 2018
@batmat batmat mentioned this pull request Dec 4, 2018
Merged
4 tasks
@batmat batmat closed this Dec 5, 2018
@batmat batmat reopened this Dec 5, 2018
@batmat batmat force-pushed the analyze-AtomicFileWriterPerfTest branch from 7119ccd to 13a6dd6 Compare December 5, 2018 10:50
@batmat batmat closed this Dec 5, 2018
@batmat batmat reopened this Dec 5, 2018
@batmat
Copy link
Member Author

batmat commented Dec 5, 2018

screenshot_20181205-213710__01
Interesting.
Need to check if that time always was so different between platforms, and if this test recently started failing on random platforms including Linux, or if only Windows.

Probably should double check what this gives on Windows. Could you possibly check the behavior of this test on your laptops running Windows @jtnord @MRamonLeon ? Thanks in advance

@batmat batmat closed this Dec 5, 2018
@batmat batmat reopened this Dec 5, 2018
@batmat
Copy link
Member Author

batmat commented Dec 5, 2018

screenshot_20181205-224812 2
Ok, so it also looks highly varying on Linux. Wut.

@batmat batmat closed this Dec 5, 2018
@batmat batmat reopened this Dec 5, 2018
@batmat batmat closed this Dec 5, 2018
@batmat batmat reopened this Dec 5, 2018
@batmat batmat closed this Dec 5, 2018
@batmat batmat reopened this Dec 5, 2018
@batmat batmat closed this Dec 6, 2018
@batmat batmat reopened this Dec 6, 2018
@batmat batmat closed this Dec 7, 2018
@batmat batmat reopened this Dec 7, 2018
@batmat
Copy link
Member Author

batmat commented Dec 7, 2018

So, it seems to be more consistently slow on Windows.
image

@batmat batmat closed this Dec 7, 2018
@batmat batmat reopened this Dec 7, 2018
@batmat
Copy link
Member Author

batmat commented Dec 7, 2018

image

@batmat batmat closed this Dec 7, 2018
@batmat batmat reopened this Dec 7, 2018
@batmat
Copy link
Member Author

batmat commented Dec 9, 2018

image

image

image

image

image

image

image

image

@batmat batmat mentioned this pull request Dec 10, 2018
Merged
3 tasks
@batmat
Copy link
Member Author

batmat commented Dec 10, 2018

Filed fix as #3797

@batmat batmat closed this Dec 10, 2018
@batmat batmat deleted the analyze-AtomicFileWriterPerfTest branch December 10, 2018 16:30
@batmat batmat mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

work-in-progress The PR is under active development, not ready to the final review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@batmat