Skip to content

@Ignore AtomicFileWriterPerfTest #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
batmat wants to merge 2 commits into from
Closed

@Ignore AtomicFileWriterPerfTest #3797

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c99747
Bump timeout to accomodate CI crazily low and varying storage perform…
batmat Dec 4, 2018
b9c9b2b
Just ignore it in CI
batmat Dec 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/src/test/java/hudson/util/AtomicFileWriterPerfTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import org.junit.Test;
import org.jvnet.hudson.test.Issue;
import org.jvnet.hudson.test.JenkinsRule;
import org.junit.Ignore;

public class AtomicFileWriterPerfTest {

Expand All @@ -22,7 +23,15 @@ public class AtomicFileWriterPerfTest {
* <p>
* So using slightly more than the worse value obtained above should avoid making this flaky and still catch
* <strong>really</strong> bad performance regressions.
*
* <p>Update December 2018: for some reason, this test started causing failures in CI suddenly.
* Was analyzed in https://github.com/jenkinsci/jenkins/pull/3788, to summarize the performances in ci.jenkins.io are
* wildly varying, to say the least, between 2.5 seconds, and 1 min 9 seconds!
*
* So bumping this here to 70 seconds, so we keep being able to catch huge regressions if someone touches the Jenkins
Copy link
Member

@jglick jglick Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obsolete comment

* serialization lower layers/AtomicFileWriter...
*/
@Ignore("cf https://github.com/jenkinsci/jenkins/pull/3788 : flaky in CI for low storage performance apparently")
@Issue("JENKINS-34855")
@Test(timeout = 50 * 1000L)
public void poorManPerformanceTestBed() throws Exception {
Expand Down