Skip to content

[JENKINS-54325] Add support for multiple footers in SimplePageDecorator #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
batmat merged 16 commits into from
Dec 12, 2018
Merged

[JENKINS-54325] Add support for multiple footers in SimplePageDecorator #3721

batmat merged 16 commits into from
Dec 12, 2018

Conversation

@jvz
Copy link
Member

@jvz jvz commented Nov 7, 2018 •
edited
Loading

Signed-off-by: Matt Sicker boards@gmail.com

See JENKINS-54325. This supersedes #3710.

Proposed changelog entries

  • Internal: login.jelly and signup.jelly now support displaying all registered SimplePageDecorator extensions in the footer rather than just the top priority one.

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@reviewbybees @scherler @Wadeck @jeffret-b @jenkinsci/code-reviewers

@jvz jvz mentioned this pull request Nov 7, 2018
Closed
4 tasks
@daniel-beck daniel-beck requested a review from scherler November 8, 2018 21:54
@jvz jvz mentioned this pull request Nov 9, 2018
Merged
@Wadeck Wadeck self-requested a review November 12, 2018 10:16
@jvz
Copy link
Member Author

jvz commented Nov 15, 2018

Rebuilding PR

@jvz jvz closed this Nov 15, 2018
@jvz jvz reopened this Nov 15, 2018
@jvz jvz closed this Nov 15, 2018
@jvz jvz reopened this Nov 15, 2018
@jvz jvz closed this Nov 15, 2018
@jvz jvz reopened this Nov 15, 2018
jvz added 3 commits November 15, 2018 14:01
@jvz
Disable frequently flaky test
a23ce43
@jvz
Add test retry logic
3d2d1dc 
Signed-off-by: Matt Sicker <boards@gmail.com>
@jvz
Simplify expressions
a074194 
Signed-off-by: Matt Sicker <boards@gmail.com>
jglick
jglick reviewed Nov 15, 2018
View reviewed changes
scherler
scherler approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@scherler scherler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTME thank you very much!

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Nov 20, 2018

@jenkinsci/core PTAL

Wadeck
Wadeck approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝

jeffret-b
jeffret-b approved these changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Wadeck Wadeck closed this Nov 29, 2018
@Wadeck
Copy link
Contributor

Wadeck commented Nov 29, 2018

Re-run the test, due to "Caused by: java.net.BindException: Address already in use"

@Wadeck Wadeck reopened this Nov 29, 2018
@Wadeck
Copy link
Contributor

Wadeck commented Nov 29, 2018

If the test passed this time and no negative feedback, we will merge it into the weekly tomorrow.

@Wadeck Wadeck added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 29, 2018
@Wadeck
Copy link
Contributor

Wadeck commented Dec 2, 2018

@jvz Seems that testDeleteRecursive_onWindows should be ignored or corrected like the other :(

@Wadeck Wadeck added needs-comments-resolved Comments in the PR need to be addressed before it can be considered for merging and removed ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback labels Dec 10, 2018
Wadeck
Wadeck approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@Wadeck Wadeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both tests that are failing:

  • hudson.util.AtomicFileWriterPerfTest
  • hudson.FilePathSEC904Test

Are known and in investigation state.

@Wadeck Wadeck added ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback and removed needs-comments-resolved Comments in the PR need to be addressed before it can be considered for merging labels Dec 10, 2018
@batmat
Copy link
Member

batmat commented Dec 11, 2018

Last PR build is:
image

Which is about to be ignored in #3797

So we can consider the current PR as "green" :).

batmat
batmat requested changes Dec 11, 2018
View reviewed changes
Copy link
Member

@batmat batmat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we must remove the now unused simpleDecorator in jelly (and likely deprecate the getSimplePageDecorator method to avoid raising the WTF/line ratio).

@Wadeck
Copy link
Contributor

Wadeck commented Dec 11, 2018

@batmat see the initial discussion on those points in #3710 which is mentioned in the description.
TL;DR: it's important to keep them

@Wadeck Wadeck requested a review from batmat December 11, 2018 12:07
@jvz
Copy link
Member Author

jvz commented Dec 11, 2018

@batmat I already tried that approach first and was rejected.

batmat
batmat approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@batmat batmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 then.

@batmat
Copy link
Member

batmat commented Dec 11, 2018

I think enough approval were given here. Let's merge this some time tomorrow or later today if nobody objects in the meantime :).

\o/

@batmat batmat self-assigned this Dec 11, 2018
@batmat batmat merged commit 404ca8d into jenkinsci:master Dec 12, 2018
@batmat batmat mentioned this pull request Dec 12, 2018
Merged
4 tasks
@jvz jvz deleted the simple-footer-decorators branch December 12, 2018 15:04
@Wadeck Wadeck mentioned this pull request Dec 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglick jglick jglick left review comments

@batmat batmat batmat approved these changes

@Wadeck Wadeck Wadeck approved these changes

+2 more reviewers

@scherler scherler scherler approved these changes

@jeffret-b jeffret-b jeffret-b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@batmat batmat

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jvz @oleg-nenashev @Wadeck @batmat @jglick @scherler @jeffret-b