WebDiscover: Allow setting labels when enrolling single web application #50853
+142
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
force-pushed
the
lisa/app-labels-ui
branch
2 times, most recently
from
540b198 to
7d16d25
Compare
kimlisa
force-pushed
the
lisa/add-v2-endpoint
branch
3 times, most recently
from
7518029 to
ef0eb7c
Compare
kimlisa
force-pushed
the
lisa/app-labels-ui
branch
from
7d16d25 to
a296cd1
Compare
kimlisa
requested review from
avatus and
rudream
and removed request for
gzdunek
ryanclark
approved these changes
Jan 10, 2025
| /> | ||
| </Flex> | ||
| <Box mt={-3} mb={3}> |
There was a problem hiding this comment.
the component above this, the FieldInput adds mb={3} that I needed to remove to make things looked spaced correctly
avatus
approved these changes
Jan 10, 2025
public-teleport-github-review-bot
bot
removed the request for review
from rudream
kimlisa
force-pushed
the
lisa/app-labels-ui
branch
from
6b28e9f to
d366469
Compare
kimlisa
added a commit
that referenced
this pull request
Jan 14, 2025
…on (#50853) * Allow labels for generic add web app flow * Update test
Merged
1 task
kimlisa
added a commit
that referenced
this pull request
Jan 15, 2025
…on (#50853) * Allow labels for generic add web app flow * Update test
kimlisa
added a commit
that referenced
this pull request
Jan 15, 2025
…on (#50853) * Allow labels for generic add web app flow * Update test
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
…ingle resource enroll (#51038) * WebDiscover: allow setting resource labels when enrolling single eks, rds, server, kube (#50606) * WebDiscover: Allow setting labels when enrolling single web application (#50853) * Allow labels for generic add web app flow * Update test * WebDiscover: allow setting labels when enrolling aws app (#50976) * WebDiscover: allow setting labels when enrolling aws app * Address CRs * Web: Fix v1 fallback with v2 endpoints (#51058) * Implement a fallback hook for re-use * Split v1 and v2 endpoints into separate funcs * Provide fallback for create app access * Provide fallback for join token suspender * Provide fallback for eks * Provide fallback for app * Address CRs
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #46976
requires:
tested in staging cloud:
changelog: Adds support for defining labels in the web UI for enrolling applications