Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Discover flows should allow to set resource labels (single enrollments) #46976

Closed
4 tasks
r0mant opened this issue Sep 30, 2024 · 2 comments
Closed
4 tasks
Assignees
Labels
discover Issues related to Teleport Discover ui ux

Comments

@r0mant
Copy link
Collaborator

r0mant commented Sep 30, 2024

Some of the resource-adding Discover flows do not allow to provide resource labels. This was intentionally omitted when we were originally implementing them but one consistent piece of feedback from SE team is that this leads to high friction during PoV's and is one of the main reasons they don't recommend these flows. Without ability to set resource labels, users have to resort to CLI to edit service config file to update the labels after having deployed it via Discover.

@r0mant r0mant added ux discover Issues related to Teleport Discover labels Sep 30, 2024
@marcoandredinis
Copy link
Contributor

marcoandredinis commented Nov 5, 2024

For SSH Server enrollments
The UI must be changed to have an optional list of labels that should be applied to the teleport.yaml configuration.

If the user adds anything there, the UI must update the token to include those labels as suggestedLabels
Endpoint:

h.PUT("/webapi/tokens", h.WithAuth(h.upsertTokenHandle))

When the installer script is fetched, it will include all the suggestedLabels in the teleport.yaml.

Note: the token already has one suggested label teleport.internal/resource-id. It must not be removed because it allows the UI to detect when the agent joins the cluster.
We should probably hide it from the UI.

For database enrollments
The UI must be changed to have an optional list of labels when the user adds a database.
This is valid for self-hosted and RDS databases.

The UI calls this endpoint

h.POST("/webapi/sites/:site/databases", h.WithClusterAuth(h.handleDatabaseCreateOrOverwrite))

Which already has the Labels field
Labels []ui.Label `json:"labels,omitempty"`

For EKS Clusters
Backend PR: #49420
The frontend must be changed to allow users to send extra labels to the resource that will be created

response, err := clt.IntegrationAWSOIDCClient().EnrollEKSClusters(ctx, &integrationv1.EnrollEKSClustersRequest{

For self-hosted Kube Clusters
The frontend must be changed to allow the user to optionally include the extra labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discover Issues related to Teleport Discover ui ux
Projects
None yet
Development

No branches or pull requests

4 participants