[v17] WebDiscover: supports defining labels for Discover flows with single resource enroll #51038
+1,449
−427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
changed the title
kimlisa
changed the title
rudream
approved these changes
Jan 14, 2025
ravicious
approved these changes
Jan 15, 2025
kimlisa
force-pushed
the
lisa/v17/backend-labels
branch
from
0b5fe71 to
c48ec81
Compare
kimlisa
force-pushed
the
lisa/v17/frontend-labels
branch
from
306903f to
93928b4
Compare
kimlisa
force-pushed
the
lisa/v17/frontend-labels
branch
from
93928b4 to
466ba11
Compare
* Implement a fallback hook for re-use * Split v1 and v2 endpoints into separate funcs * Provide fallback for create app access * Provide fallback for join token suspender * Provide fallback for eks * Provide fallback for app * Address CRs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #50606 #50853 #50976 #51058 to branch/v17
manual, but all commits were cleanly cherry-picked
changelog: Adds support for defining labels in the web UI Discover flows for single resource enroll (server, AWS and web applications, Kubernetes, EKS, RDS)