Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support labels in "add application" magic link #23096

Open
r0mant opened this issue Mar 15, 2023 · 3 comments
Open

Support labels in "add application" magic link #23096

r0mant opened this issue Mar 15, 2023 · 3 comments
Labels
discover Issues related to Teleport Discover feature-request Used for new features in Teleport, improvements to current should be #enhancements

Comments

@r0mant
Copy link
Collaborator

r0mant commented Mar 15, 2023

Users would like to be able to provide labels in the application install link:

sudo bash -c "$(curl -fsSL 'https://example.com/scripts/<key>/install-app.sh?name=test&uri=https%3A%2F%2Flocalhost%3A443')"

The install script itself supports labels but they can't be passed via this API.

@r0mant r0mant added feature-request Used for new features in Teleport, improvements to current should be #enhancements discover Issues related to Teleport Discover labels Mar 15, 2023
@r0mant
Copy link
Collaborator Author

r0mant commented Mar 15, 2023

@ryanclark @marcoandredinis Just FYI. We can probably include this when we're updating Teleport Discover flow for applications (maybe in Q2?)

@marcoandredinis
Copy link
Contributor

We can also re-use the SuggestedLabels prop of the Token.

It would work like this:

  • user enters the labels they want (we must limit labels count and label size)
  • a new token is created which includes the SuggestedLabels
  • when the script is generated, it includes those labels as part of the teleport.yaml config

It currently works for Nodes and only a server side generated Label is present (teleport.dev/resource-id).
However, I think this is something we should converge.

@kimlisa
Copy link
Contributor

kimlisa commented Jan 16, 2025

this is different from the requested feature from this issue, but there is now support in the web UI for setting labels during the add app discover flows: (see #46976)

https://github.com/gravitational/teleport.e/pull/5810 #50853 #50976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discover Issues related to Teleport Discover feature-request Used for new features in Teleport, improvements to current should be #enhancements
Projects
None yet
Development

No branches or pull requests

3 participants