Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrations: support self-hosted providers from gkdev #3901

Closed
d13 opened this issue Dec 20, 2024 · 1 comment · Fixed by #3922
Closed

Integrations: support self-hosted providers from gkdev #3901

d13 opened this issue Dec 20, 2024 · 1 comment · Fixed by #3922
Assignees
@sergeibbb
Labels
area-autolinks Issues or features related to autolinks area-integrations Issues or features related to integrations area-launchpad Issues or features related to Launchpad
Milestone
16.2

Comments

@d13
Copy link
Member

d13 commented Dec 20, 2024 •
edited by sergeibbb
Loading

The goal is not to just convert over to GKdev like our other providers. We need to continue support of multiple instances of self-hosted and GKdev only supports one instance.

High level changes:

  • ✅ Send users to GKdev to connect to self-hosted GitHub or GitLab
    • ✅ if the integration exists on GKdev show the enable/disable toggle on the remote
    • ❌ if the integration does not exist: show the enable toggle and send user to GKdev
    • ✅ Show the "Connect GitHub Enterprise" on the Home View
  • ✅ Existing self-hosted integations (GitHub or GitLab) on GKdev, bring those into our system, but still support our custom self-hosted auth
  • ✅ Once we have the info, we need to register a custom provider
  • ➡️ A follow-up (Launchpad): Support GitHub Enterprise (GKDev) in Launchpad #3923
  • ➡️ Another follow-up (GitLab): Support GitLab Self Managed integration from GKDev #3934

👍 The code where this happens in remoteProviders.ts
👍 Essentially, we can just take the list of custom remotes and add another custom entry from the GKdev data, at runtime. We don't want to update their settings.json (though it might be an easy path for initial testing).

Potential gotchas:

  • During development, if GKdev doesn't provide the correct data, let's just temporarily stub the data in while we wait for GKDS/GKdev to provide the info (aka URL)

Testing

  • ✅ issue linking works
  • ✅ pull requests work
@eamodio eamodio added this to the 16.2 milestone Dec 20, 2024
@d13 d13 modified the milestone: 16.2 Dec 20, 2024
@d13 d13 added area-integrations Issues or features related to integrations area-autolinks Issues or features related to autolinks area-launchpad Issues or features related to Launchpad labels Dec 20, 2024
sergeibbb added a commit that referenced this issue Jan 3, 2025
@sergeibbb
Add support for GKDev Cloud GitHub Enterprise integration
0958984 
(#3901)
sergeibbb added a commit that referenced this issue Jan 7, 2025
@sergeibbb
Associate a Cloud GitHub Enterprise provider with remote by its domain
377483f 
(#3901)
sergeibbb added a commit that referenced this issue Jan 8, 2025
@sergeibbb
Add support for GKDev Cloud GitHub Enterprise integration
173e454 
(#3901)
sergeibbb added a commit that referenced this issue Jan 8, 2025
@sergeibbb
Associate a Cloud GitHub Enterprise provider with remote by its domain
038528c 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Add support for GKDev Cloud GitHub Enterprise integration
dba92c4 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Associate a Cloud GitHub Enterprise provider with remote by its domain
d455109 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Adds GitHub Enterprize menu item and filter out its icon in the bar
a378b88 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Changes order of GitHub.com and GitHub Enterprise in the dropdown list
351d150 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Adds GitHub Enterprize menu item
da3b690 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Changes order of GitHub.com and GitHub Enterprise in the dropdown list
0d9bbe4 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Add support for GKDev Cloud GitHub Enterprise integration
5e57878 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Associate a Cloud GitHub Enterprise provider with remote by its domain
1fb39e1 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Adds GitHub Enterprize menu item
afb8a28 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Changes order of GitHub.com and GitHub Enterprise in the dropdown list
2256ffc 
(#3901)
sergeibbb added a commit that referenced this issue Jan 9, 2025
@sergeibbb
Filters out GitHub's icon in the bar
9ecdc09 
(#3901)
sergeibbb added a commit that referenced this issue Jan 10, 2025
@sergeibbb
Add support for GKDev Cloud GitHub Enterprise integration
a665cdf 
(#3901)
sergeibbb added a commit that referenced this issue Jan 10, 2025
@sergeibbb
Associate a Cloud GitHub Enterprise provider with remote by its domain
f68746f 
(#3901)
sergeibbb added a commit that referenced this issue Jan 10, 2025
@sergeibbb
Adds GitHub Enterprize menu item
b5f3d2a 
(#3901)
sergeibbb added a commit that referenced this issue Jan 10, 2025
@sergeibbb
Changes order of GitHub.com and GitHub Enterprise in the dropdown list
694807f 
(#3901)
sergeibbb added a commit that referenced this issue Jan 10, 2025
@sergeibbb
Filters out GitHub's icon in the bar
54e4947 
(#3901)
sergeibbb added a commit that referenced this issue Jan 10, 2025
@sergeibbb
Makes sure that cloud version of GitHubEnterprise is used when needed
6e30e39 
(#3901)
sergeibbb added a commit that referenced this issue Jan 13, 2025
@sergeibbb
Add support for GKDev Cloud GitHub Enterprise integration
c0671b6 
(#3901)
sergeibbb added a commit that referenced this issue Jan 13, 2025
@sergeibbb
Associate a Cloud GitHub Enterprise provider with remote by its domain
1349e12 
(#3901)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Filters out GitHub's icon in the bar
920c654 
(#3901, #3922)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Makes sure that cloud version of GitHubEnterprise is used when needed
7c3048a 
(#3901, #3922)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Rename config integration descriptor
2292551 
(#3901, #3922)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Adds a todo for a follow-up ticket
3a04d81 
(#3901, #3922)
axosoft-ramint added a commit that referenced this issue Jan 15, 2025
@sergeibbb @eamodio @axosoft-ramint
Integrations support self hosted providers from gkdev (#3901) (#3922)
cb7e263 
* Adds support for GKDev Cloud GitHub Enterprise integration
(#3901, #3922)

* Associates a Cloud GitHub Enterprise provider with remote by its domain
(#3901, #3922)

* Adds GitHub Enterprize menu item
(#3901, #3922)

* Filters out GitHub's icon in the bar
(#3901, #3922)

* Makes sure that cloud version of GitHubEnterprise is used when needed
(#3901, #3922)

* Updates (minor) from code review

* Stores and uses stored values for configured integration descriptors

* Rename config integration descriptor
(#3901, #3922)

* Adds a todo for a follow-up ticket
(#3901, #3922)

---------

Co-authored-by: Eric Amodio <[email protected]>
Co-authored-by: Ramin Tadayon <[email protected]>
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Adds support for GKDev Cloud GitHub Enterprise integration
b8dd1b0 
(#3901, #3922)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Associates a Cloud GitHub Enterprise provider with remote by its domain
a27e8de 
(#3901, #3922)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Adds GitHub Enterprize menu item
714d3ed 
(#3901, #3922)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Filters out GitHub's icon in the bar
b33027c 
(#3901, #3922)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Makes sure that cloud version of GitHubEnterprise is used when needed
97f89b4 
(#3901, #3922)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Rename config integration descriptor
c099605 
(#3901, #3922)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Adds a todo for a follow-up ticket
9c658df 
(#3901, #3922)
sergeibbb added a commit that referenced this issue Jan 15, 2025
@sergeibbb
Prevents caching a Cloud GitHub Enterprise integration without domain
cab27e1 
(#3901)
@sergeibbb sergeibbb mentioned this issue Jan 15, 2025
Merged
7 tasks
axosoft-ramint pushed a commit that referenced this issue Jan 15, 2025
@sergeibbb
Prevents caching a Cloud GitHub Enterprise integration without domain (…
40f8024 
…#3933)

(#3901)
@sergeibbb sergeibbb mentioned this issue Jan 16, 2025
Closed
@axosoft-ramint axosoft-ramint added pending-release Resolved but not yet released to the stable edition feature labels Jan 16, 2025
sergeibbb added a commit that referenced this issue Jan 17, 2025
@sergeibbb
Adds search by URL for GitHub Enterprise to the Launchpad
7134b9c 
(#3901)
@d13 d13 removed the pending-release Resolved but not yet released to the stable edition label Feb 11, 2025
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this issue Feb 25, 2025
@sergeibbb @benferizi
Adds support for GKDev Cloud GitHub Enterprise integration
6cce8f5 
(gitkraken#3901, gitkraken#3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this issue Feb 25, 2025
@sergeibbb @benferizi
Adds GitHub Enterprize menu item
63c5d59 
(gitkraken#3901, gitkraken#3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this issue Feb 25, 2025
@sergeibbb @benferizi
Filters out GitHub's icon in the bar
f144044 
(gitkraken#3901, gitkraken#3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this issue Feb 25, 2025
@sergeibbb @benferizi
Makes sure that cloud version of GitHubEnterprise is used when needed
e5533c2 
(gitkraken#3901, gitkraken#3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this issue Feb 25, 2025
@sergeibbb @benferizi
Rename config integration descriptor
e855ec3 
(gitkraken#3901, gitkraken#3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this issue Feb 25, 2025
@sergeibbb @benferizi
Adds a todo for a follow-up ticket
9e20eb9 
(gitkraken#3901, gitkraken#3922)
@sergeibbb sergeibbb mentioned this issue Mar 5, 2025
Closed
2 tasks
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sergeibbb sergeibbb

Labels
area-autolinks Issues or features related to autolinks area-integrations Issues or features related to integrations area-launchpad Issues or features related to Launchpad
Projects
None yet
Milestone
16.2
Development

Successfully merging a pull request may close this issue.

Integrations support self hosted providers from gkdev (#3901) gitkraken/vscode-gitlens
4 participants
@d13 @eamodio @axosoft-ramint @sergeibbb