Changes order of GitHub.com and GitHub Enterprise in the dropdown list

(#3901)

Author: sergeibbb

src/constants.integrations.ts

@@ -39,19 +39,22 @@ export interface IntegrationDescriptor {
 	name: string;
 	icon: string;
 	supports: IntegrationFeatures[];
+	weight?: number;
 }
 export const supportedCloudIntegrationDescriptors: IntegrationDescriptor[] = [
 	{
 		id: HostingIntegrationId.GitHub,
 		name: 'GitHub',
 		icon: 'gl-provider-github',
 		supports: ['prs', 'issues'],
+		weight: 1,
 	},
 	{
 		id: SelfHostedIntegrationId.CloudGitHubEnterprise,
 		name: 'GitHub Enterprise',
 		icon: 'gl-provider-github',
 		supports: ['prs', 'issues'],
+		weight: 0,
 	},
 	{
 		id: HostingIntegrationId.GitLab,

src/webviews/home/homeWebview.ts

@@ -830,22 +830,31 @@ export class HomeWebviewProvider implements WebviewProvider<State, State, HomeWe
 			);
 
 			const integrationsResults = await Promise.allSettled(promises);
-			const integrations = [...filterMap(integrationsResults, r => getSettledValue(r))];
+			const integrations: IntegrationState[] = [...filterMap(integrationsResults, r => getSettledValue(r))];
 
 			this._defaultSupportedCloudIntegrations ??= supportedCloudIntegrationDescriptors.map(d => ({
 				...d,
 				connected: false,
 			}));
 
 			// union (uniquely by id) with supportedCloudIntegrationDescriptors
-			integrations.push(
-				...this._defaultSupportedCloudIntegrations.filter(d => !integrations.some(i => i.id === d.id)),
-			);
-			integrations.sort(
-				(a, b) =>
+			this._defaultSupportedCloudIntegrations.forEach(d => {
+				const i = integrations.find(i => i.id === d.id);
+				if (i == null) {
+					integrations.push(d);
+				} else if (d.weight !== undefined) {
+					i.weight = d.weight;
+				}
+			});
+			integrations.sort((a, b) => {
+				if (a.weight !== undefined && b.weight !== undefined) {
+					return -(a.weight - b.weight);
+				}
+				return (
 					supportedOrderedCloudIntegrationIds.indexOf(a.id) -
-					supportedOrderedCloudIntegrationIds.indexOf(b.id),
-			);
+					supportedOrderedCloudIntegrationIds.indexOf(b.id)
+				);
+			});
 
 			this._integrationStates = integrations;
 		}