Skip to content

Commit 40f8024

Browse files
authored
Prevents caching a Cloud GitHub Enterprise integration without domain (#3933)
(#3901)
1 parent cfe8bce commit 40f8024

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/plus/integrations/integrationService.ts

+5-3
Original file line numberDiff line numberDiff line change
@@ -479,17 +479,19 @@ export class IntegrationService implements Disposable {
479479
SelfHostedIntegrationId.CloudGitHubEnterprise,
480480
);
481481
if (existingConfigured?.length) {
482-
const { domain } = existingConfigured[0];
483-
if (domain == null) throw new Error(`Domain is required for '${id}' integration`);
482+
const { domain: configuredDomain } = existingConfigured[0];
483+
if (configuredDomain == null) throw new Error(`Domain is required for '${id}' integration`);
484484
integration = new (
485485
await import(/* webpackChunkName: "integrations" */ './providers/github')
486486
).GitHubEnterpriseIntegration(
487487
this.container,
488488
this.authenticationService,
489489
this.getProvidersApi.bind(this),
490-
domain,
490+
configuredDomain,
491491
id,
492492
);
493+
// assign domain because it's part of caching key:
494+
domain = configuredDomain;
493495
break;
494496
}
495497

0 commit comments

Comments
 (0)