Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrations support self hosted providers from gkdev (#3901) #3922

Merged
merged 9 commits into from
Jan 15, 2025
Merged

Integrations support self hosted providers from gkdev (#3901) #3922

merged 9 commits into from
Jan 15, 2025

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jan 13, 2025 •
edited
Loading

Description

#3901

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb linked an issue Jan 13, 2025 that may be closed by this pull request
Integrations: support self-hosted providers from gkdev #3901
Closed
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Adds support for GKDev Cloud GitHub Enterprise integration
9ea6153 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Associates a Cloud GitHub Enterprise provider with remote by its domain
d96fa7f 
(#3901, #3922)
@sergeibbb sergeibbb force-pushed the 3901-integrations-support-self-hosted-providers-from-gkdev branch from ede3ded to f00ba5b Compare January 13, 2025 14:28
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Adds GitHub Enterprize menu item
18e3d01 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Changes order of GitHub.com and GitHub Enterprise in the dropdown list
8c6c5c0 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Filters out GitHub's icon in the bar
c7d5292 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Makes sure that cloud version of GitHubEnterprise is used when needed
f00ba5b 
(#3901, #3922)
@sergeibbb
Copy link
Member Author

@eamodio, @axosoft-ramint, @d13,

To sum up what is happening here: new type of integration "cloud-github-enterprise" that works as enterprise but gets authorization as cloud.

sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Adds support for GKDev Cloud GitHub Enterprise integration
0879e85 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Associates a Cloud GitHub Enterprise provider with remote by its domain
31e969c 
(#3901, #3922)
@sergeibbb sergeibbb force-pushed the 3901-integrations-support-self-hosted-providers-from-gkdev branch from f00ba5b to b15b070 Compare January 13, 2025 17:06
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Adds GitHub Enterprize menu item
72d3c2d 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Changes order of GitHub.com and GitHub Enterprise in the dropdown list
e34a903 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Filters out GitHub's icon in the bar
4a285c0 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Makes sure that cloud version of GitHubEnterprise is used when needed
b15b070 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Adds support for GKDev Cloud GitHub Enterprise integration
5622e88 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Associates a Cloud GitHub Enterprise provider with remote by its domain
03f53c8 
(#3901, #3922)
@sergeibbb sergeibbb force-pushed the 3901-integrations-support-self-hosted-providers-from-gkdev branch from b15b070 to fb6f815 Compare January 13, 2025 17:07
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Adds GitHub Enterprize menu item
3025cc6 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Changes order of GitHub.com and GitHub Enterprise in the dropdown list
21947fa 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Filters out GitHub's icon in the bar
32bb670 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 13, 2025
@sergeibbb
Makes sure that cloud version of GitHubEnterprise is used when needed
fb6f815 
(#3901, #3922)
eamodio
eamodio approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@eamodio eamodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good - though I did have a few questions.

sergeibbb added a commit that referenced this pull request Jan 14, 2025
@sergeibbb
Adds support for GKDev Cloud GitHub Enterprise integration
a6c7542 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 14, 2025
@sergeibbb
Associates a Cloud GitHub Enterprise provider with remote by its domain
221cdef 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 14, 2025
@sergeibbb
Adds GitHub Enterprize menu item
423bcc0 
(#3901, #3922)
eamodio
eamodio reviewed Jan 15, 2025
View reviewed changes
eamodio
eamodio reviewed Jan 15, 2025
View reviewed changes
src/plus/integrations/authentication/integrationAuthentication.ts
Comment on lines 104 to +108
await this.container.storage.deleteSecret(key);
await this.authenticationService.removeConfigured({
integrationId: this.authProviderId,
domain: isSelfHostedIntegrationId(this.authProviderId) ? sessionId : undefined,
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit for another day, but it feels like these operations should be combined into the AuthService rather than in the base class.

@axosoft-ramint
Copy link
Contributor

@sergeibbb Please feel free to take over from here including @eamodio 's review comments on my "configured integrations" changes.

@sergeibbb sergeibbb force-pushed the 3901-integrations-support-self-hosted-providers-from-gkdev branch from 15c7e7f to 672297d Compare January 15, 2025 17:47
@axosoft-ramint axosoft-ramint merged commit cb7e263 into main Jan 15, 2025
3 checks passed
sergeibbb added a commit that referenced this pull request Jan 15, 2025
@sergeibbb
Adds support for GKDev Cloud GitHub Enterprise integration
b8dd1b0 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 15, 2025
@sergeibbb
Associates a Cloud GitHub Enterprise provider with remote by its domain
a27e8de 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 15, 2025
@sergeibbb
Adds GitHub Enterprize menu item
714d3ed 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 15, 2025
@sergeibbb
Filters out GitHub's icon in the bar
b33027c 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 15, 2025
@sergeibbb
Makes sure that cloud version of GitHubEnterprise is used when needed
97f89b4 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 15, 2025
@sergeibbb
Rename config integration descriptor
c099605 
(#3901, #3922)
sergeibbb added a commit that referenced this pull request Jan 15, 2025
@sergeibbb
Adds a todo for a follow-up ticket
9c658df 
(#3901, #3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this pull request Feb 25, 2025
@sergeibbb @benferizi
Adds support for GKDev Cloud GitHub Enterprise integration
6cce8f5 
(gitkraken#3901, gitkraken#3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this pull request Feb 25, 2025
@sergeibbb @benferizi
Adds GitHub Enterprize menu item
63c5d59 
(gitkraken#3901, gitkraken#3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this pull request Feb 25, 2025
@sergeibbb @benferizi
Filters out GitHub's icon in the bar
f144044 
(gitkraken#3901, gitkraken#3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this pull request Feb 25, 2025
@sergeibbb @benferizi
Makes sure that cloud version of GitHubEnterprise is used when needed
e5533c2 
(gitkraken#3901, gitkraken#3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this pull request Feb 25, 2025
@sergeibbb @benferizi
Rename config integration descriptor
e855ec3 
(gitkraken#3901, gitkraken#3922)
benferizi pushed a commit to benferizi/vscode-gitlens that referenced this pull request Feb 25, 2025
@sergeibbb @benferizi
Adds a todo for a follow-up ticket
9e20eb9 
(gitkraken#3901, gitkraken#3922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamodio eamodio eamodio approved these changes

@axosoft-ramint axosoft-ramint axosoft-ramint left review comments

@d13 d13 Awaiting requested review from d13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrations: support self-hosted providers from gkdev
3 participants
@sergeibbb @axosoft-ramint @eamodio