Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents caching a Cloud GitHub Enterprise integration without domain #3933

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jan 15, 2025

(#3901)

This situation happens because an integration is cached twice with a real domain and with undefined:
image

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@axosoft-ramint axosoft-ramint merged commit 40f8024 into main Jan 15, 2025
3 checks passed
@axosoft-ramint axosoft-ramint deleted the 3901-fix-caching-under-undefined-domain branch January 15, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants