Check for config processing errors in coordinator unit tests #10203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
added
flaky-test
swiatekm
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
cmacknz
approved these changes
Sep 29, 2025
swiatekm
force-pushed
the
test/fix-coordinator-unit-test
branch
from
a0d7012 to
c13cd29
Compare
|
|
@Mergifyio backport 8.18 8.19 9.0 9.1 |
💚 Build Succeeded
History
cc @swiatekm |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
(cherry picked from commit 0ba2ea6) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_unit_test.go
mergify bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
(cherry picked from commit 0ba2ea6)
mergify bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
(cherry picked from commit 0ba2ea6) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_unit_test.go
This was referenced Sep 30, 2025
mergify bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
(cherry picked from commit 0ba2ea6) # Conflicts: # internal/pkg/agent/application/coordinator/coordinator_unit_test.go
3 tasks
swiatekm
added a commit
that referenced
this pull request
Sep 30, 2025
(cherry picked from commit 0ba2ea6)
swiatekm
added a commit
that referenced
this pull request
Sep 30, 2025
…#10214) (cherry picked from commit 0ba2ea6) Co-authored-by: Mikołaj Świątek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds checks for config processing errors in coordinator unit tests. These tests have been flaky in the past, and the lack of diagnostic information makes it difficult to find the root cause.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testRelated issues