Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 30, 2025

What does this PR do?

Adds checks for config processing errors in coordinator unit tests. These tests have been flaky in the past, and the lack of diagnostic information makes it difficult to find the root cause.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Related issues


This is an automatic backport of pull request #10203 done by [Mergify](https://mergify.com).

(cherry picked from commit 0ba2ea6)

# Conflicts:
#	internal/pkg/agent/application/coordinator/coordinator_unit_test.go
@mergify mergify bot requested a review from a team as a code owner September 30, 2025 12:21
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Sep 30, 2025
@mergify mergify bot requested review from pkoutsovasilis and michel-laterman and removed request for a team September 30, 2025 12:21
Copy link
Contributor Author

mergify bot commented Sep 30, 2025

Cherry-pick of 0ba2ea6 has failed:

On branch mergify/bp/9.1/pr-10203
Your branch is up to date with 'origin/9.1'.

You are currently cherry-picking commit 0ba2ea683.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   internal/pkg/agent/application/coordinator/coordinator_unit_test.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team flaky-test Unstable or unreliable test cases. skip-changelog chore Tasks that just need to be done, they are neither bug, nor enhancements labels Sep 30, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@swiatekm swiatekm closed this Sep 30, 2025
@swiatekm swiatekm deleted the mergify/bp/9.1/pr-10203 branch September 30, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport chore Tasks that just need to be done, they are neither bug, nor enhancements conflicts There is a conflict in the backported pull request flaky-test Unstable or unreliable test cases. skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants