-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Restructure and comment the tau embedding method #48408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure and comment the tau embedding method #48408
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48408/45306
|
|
A new Pull Request was created by @winterchristian for master. It involves the following packages:
@antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @rappoccio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
TauAnalysis/MCEmbeddingTools/plugins/MuMuForEmbeddingSelector.cc
Outdated
Show resolved
Hide resolved
TauAnalysis/MCEmbeddingTools/test/run_2016postVFPUL_workflow_tests.sh
Outdated
Show resolved
Hide resolved
|
@smuzaffar will RAW files used as input for unit tests in |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48408/45308
|
|
Pull request #48408 was updated. @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @rappoccio can you please check and sign again. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48408/45348
|
|
Pull request #48408 was updated. @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @rappoccio can you please check and sign again. |
|
please test |
|
+Upgrade |
|
+simulation |
|
+1 |
|
@ftenchini, @mandrenguyen, and @AdrianoDee can you please approve this, too. I think only your approval is missing. |
|
+pdmv |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
…he tau embedding method
…_0_pre1_improveCode Restructure and comment the tau embedding method (cherry picked from commit 1cf5c12)
…_0_pre1_improveCode Restructure and comment the tau embedding method (cherry picked from commit 1cf5c12)
…_0_pre1_improveCode Restructure and comment the tau embedding method (cherry picked from commit 1cf5c12)
PR description:
This PR restructures and cleans the tau embedding method (
TauAnalysis/MCEmbeddingTools) so that it is possible to produce RUN 3 tau embedding samples with CMS submission workflows.One goal was to remove the need of
--customiseor--customise_commandsin the tau embeddingcmsDriver.pycommands.This was possible due to modifiers and the possibility to add python config fragments to some
cmsDriver.pysteps.Only the
HLTstep required additional modification of thecmsDriver.pyconfig builder.The other goal of this PR is to have more understandable, better commented code and therefore sustainable code.
Tau embedding
cmsDriver.pycommandsWith the changes introduced in this PR, tau embedding samples can be produced using the following
cmsDriver.pycommands.Selection
cmsDriver.py \ --step RAW2DIGI,L1Reco,RECO,PAT,FILTER:TauAnalysis/MCEmbeddingTools/Selection_FILTER_cff.makePatMuonsZmumuSelection \ --processName SELECT \ --data \ --scenario pp \ --conditions auto:run3_data \ --era Run3_2024 \ --eventcontent TauEmbeddingSelection \ --datatier RAWRECO \ --filein "root://cmsdcache-kit-disk.gridka.de:1094//store/data/Run2024C/Muon0/RAW/v1/000/380/115/00000/00979445-916c-42e2-8038-428d7bd4f176.root" \ --fileout ...LHE and Cleaning
Simulation Gen
Simulation HLT
Simulation Reco
Merging
cmsDriver.py \ --step USER:TauAnalysis/MCEmbeddingTools/Merging_USER_cff.merge_step,PAT \ --processName MERGE \ --data \ --scenario pp \ --conditions auto:run3_data \ --era Run3_2024 \ --eventcontent TauEmbeddingMergeMINIAOD \ --datatier USER \ --procModifiers tau_embedding_merging \ --inputCommands 'keep *_*_*_*' \ --filein ... \ --fileout ...NanoAOD
PR validation:
I had to disable the tests, as I first have to get RAW samples from tape to create a small set of samples I can use. The test
.rootfiles right now are only useable for the old structure.I will deliver tests in the next pull request.
UPDATE
I reactivated the unit tests as I realized I can use the RAW samples from the release validation tests.
Both, the unit tests as the release validation tests worked locally.