Skip to content

Conversation

@winterchristian
Copy link
Contributor

PR description:

This is a backport for #48408. It's needed to produce tau embedding samples with 2024 data, because this is the last branch with the 2024 HLT menu.

PR validation:

Unit tests and release validations (136.901,136.902,136.903,136.904,136.905,136.906) are implemented and tested.

Christian Winter and others added 30 commits September 16, 2025 16:52
(cherry picked from commit 1937801)
…orStateFilter during HLT step

(cherry picked from commit a059d00)
* Revert changes of commit 064da79 and replace detector state checks with simple 'True' filters

* add a explaining comment

---------

Co-authored-by: Chris Winter <44822168+winterchristian@users.noreply.github.com>
(cherry picked from commit d27b7fe)
(cherry picked from commit c55bde0)
(cherry picked from commit 36d2593)
(cherry picked from commit a26aa7d)
(cherry picked from commit 1ca62c9)
…cmsDriver HLT step

(cherry picked from commit 96339e1)
(cherry picked from commit b8725c6)
(cherry picked from commit 0b343c5)
(cherry picked from commit 4e25dd6)
* add special tau embedding EventContents

* add NANOAOD to NanoAOD event content name to be handled properly

* adapt eventcontent in cmsDriver commands

---------

Co-authored-by: Christian Winter <c.winter@kit.edu>
(cherry picked from commit 7650c60)
(cherry picked from commit e673930)
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

-1

Failed Tests: RelVals
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c7027/48520/summary.html
COMMIT: 0ebba93
CMSSW: CMSSW_14_2_X_2025-10-05-0000/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49022/48520/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 2022.002001DAS Error

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001_NANOmc106Xul16v2 3.074 3.074 0.000 ( +0.0% ) 5.76 6.05 -4.8% 2.417 2.520
2500.002_NANOmc106Xul17v2 3.191 3.191 0.000 ( +0.0% ) 5.08 5.40 -5.9% 2.809 2.961
2500.003_NANOmc106Xul18v2 3.132 3.132 0.000 ( +0.0% ) 5.36 5.60 -4.4% 2.818 2.939
2500.011_NANOdata106Xul16v2 1.643 1.643 0.000 ( +0.0% ) 9.40 9.40 +0.0% 2.473 2.623
2500.012_NANOdata106Xul17v2 2.183 2.183 0.000 ( +0.0% ) 5.34 5.69 -6.2% 2.628 2.809
2500.013_NANOdata106Xul18v2 1.998 1.998 0.000 ( +0.0% ) 7.63 7.89 -3.3% 2.548 2.712
2500.021_NANOmcUL16APVreMINI 0.022 0.022 -0.000 ( -0.2% ) 1.91 1.87 +2.1% 2.374 2.593
2500.022_NANOmcUL16reMINI 0.022 0.022 0.000 ( +0.0% ) 1.86 1.81 +2.6% 2.373 2.582
2500.023_NANOmcUL17reMINI 0.022 0.022 0.000 ( +0.2% ) 1.76 1.73 +1.9% 2.314 2.444
2500.024_NANOmcUL18reMINI 0.022 0.022 0.000 ( +0.0% ) 1.43 1.44 -0.3% 2.496 2.686
2500.031_NANOdataUL16APVreMINI 0.035 0.035 0.000 ( +0.0% ) 1.61 1.59 +1.2% 2.451 2.658
2500.032_NANOdataUL16reMINI 0.036 0.036 0.000 ( +0.0% ) 1.65 1.62 +1.6% 2.395 2.613
2500.033_NANOdataUL17reMINI 0.037 0.037 0.000 ( +0.0% ) 1.57 1.55 +1.0% 2.490 2.693
2500.034_NANOdataUL18reMINI 0.036 0.036 0.000 ( +0.0% ) 1.55 1.56 -0.5% 2.464 2.666
2500.101_NANOmc130X 2.801 2.801 0.000 ( +0.0% ) 15.77 15.41 +2.3% 2.461 2.619
2500.111_NANOdata130Xrun3 1.461 1.461 0.000 ( +0.0% ) 29.63 28.86 +2.7% 2.200 2.322
2500.112_NANOdata130Xrun3 1.881 1.881 0.000 ( +0.0% ) 24.35 23.50 +3.6% 2.177 2.402
2500.131_ScoutingNANOdata130Xrun3 0.747 0.747 0.000 ( +0.0% ) 36.28 34.85 +4.1% 1.361 1.499
2500.201_NANOmc140X 2.636 2.636 0.000 ( +0.0% ) 12.63 12.88 -2.0% 2.035 2.181
2500.211_NANOdata140Xrun3 1.804 1.804 0.000 ( +0.0% ) 25.40 24.78 +2.5% 2.164 2.394
2500.212_NANOdata140Xrun3 2.200 2.200 0.000 ( +0.0% ) 21.51 20.18 +6.6% 2.201 2.478
2500.221_muPOGNANOmc140X 2.036 2.036 0.000 ( +0.0% ) 13.85 13.75 +0.7% 1.873 2.100
2500.222_EGMNANOmc140X 3.437 3.437 0.000 ( +0.0% ) 13.05 12.56 +3.9% 1.947 2.196
2500.223_BTVNANOmc140X 9.403 9.403 0.000 ( +0.0% ) 4.02 3.97 +1.2% 2.014 2.268
2500.224_jmeNANOmc140X 6.259 6.259 0.000 ( +0.0% ) 1.32 1.32 -0.2% 2.007 2.254
2500.225_jmeNANOrePuppimc140X 6.306 6.306 0.000 ( +0.0% ) 1.21 1.23 -2.0% 2.212 2.469
2500.226_lepTrackInfoNANOmc140X 3.131 3.131 0.000 ( +0.0% ) 13.57 13.36 +1.5% 1.949 2.193
2500.227_ScoutingNANOmc140X 1.437 1.437 0.000 ( +0.0% ) 22.95 22.62 +1.4% 1.307 1.441
2500.231_muPOGNANO140Xrun3 1.454 1.454 0.000 ( +0.0% ) 21.72 21.01 +3.4% 2.074 2.282
2500.232_EGMNANOdata140Xrun3 2.459 2.459 0.000 ( +0.0% ) 20.46 19.44 +5.3% 2.139 2.392
2500.233_BTVNANOdata140Xrun3 4.952 4.952 0.000 ( +0.0% ) 5.66 5.79 -2.1% 2.192 2.454
2500.234_jmeNANOdata140Xrun3 3.838 3.838 0.000 ( +0.0% ) 1.66 1.69 -1.5% 2.191 2.429
2500.235_jmeNANOrePuppidata140Xrun3 3.869 3.869 0.000 ( +0.0% ) 1.54 1.58 -2.6% 2.358 2.619
2500.236_lepTrackInfoNANOdata140Xrun3 2.249 2.249 0.000 ( +0.0% ) 20.55 21.15 -2.8% 2.099 2.387
2500.237_ScoutingNANOdata140Xrun3 1.016 1.016 0.000 ( +0.0% ) 32.50 32.85 -1.1% 1.326 1.464
2500.241_l1DPGNANO140Xrun3 9.404 9.404 0.000 ( +0.0% ) 6.71 6.90 -2.8% 1.778 1.915
2500.242_muDPGNANO140Xrun3 10.331 10.331 0.000 ( +0.0% ) 1.54 1.57 -2.1% 1.677 1.712
2500.243_muDPGNANOBkg140Xrun3 2.712 2.712 0.000 ( +0.0% ) 14.99 15.75 -4.8% 1.056 1.075
2500.244_hcalDPGNANO140Xrun3 485.976 485.976 0.000 ( +0.0% ) 1.09 1.09 -0.3% 1.565 1.686
2500.245_hcalDPGCalibNANO140Xrun3 823.202 823.202 0.000 ( +0.0% ) 1.43 1.41 +1.4% 1.544 1.675
2500.901_TTbarMINIAOD10.6_UL18v2 1.777 1.777 0.000 ( +0.0% ) 43.06 45.39 -5.1% 1.339 1.417
2500.902_TTbarMINIAOD14.0 1.627 1.627 0.000 ( +0.0% ) 45.97 45.52 +1.0% 1.296 1.321
2500.911_DYToLL_M-50_13TeV_pythia8 14.041 14.041 0.000 ( +0.0% ) 8.15 8.31 -2.0% 1.046 1.087
2500.912_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 0.199 0.171 0.029 ( +16.9% ) 2.86 2.62 +9.2% 0.975 0.975
2500.913_TTbar_Pow_LHE_13TeV 0.110 0.110 0.000 ( +0.0% ) 2.57 2.26 +13.7% 0.982 0.977

NANO Comparison Summary

Summary:

  • You potentially added 217 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 74922
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 74922
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

please test
(failure unrelated)

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2025

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c7027/48524/summary.html
COMMIT: 0ebba93
CMSSW: CMSSW_14_2_X_2025-10-05-0000/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49022/48524/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 282 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3596288
  • DQMHistoTests: Total failures: 2418
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3593850
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 206 log files, 177 edm output root files, 47 DQM output files
  • TriggerResults: found differences in 1 / 45 workflows

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001_NANOmc106Xul16v2 3.074 3.074 0.000 ( +0.0% ) 6.05 6.05 -0.0% 2.523 2.520
2500.002_NANOmc106Xul17v2 3.191 3.191 0.000 ( +0.0% ) 5.40 5.40 +0.1% 2.955 2.961
2500.003_NANOmc106Xul18v2 3.132 3.132 0.000 ( +0.0% ) 5.62 5.60 +0.3% 2.935 2.939
2500.011_NANOdata106Xul16v2 1.643 1.643 0.000 ( +0.0% ) 9.81 9.40 +4.4% 2.630 2.623
2500.012_NANOdata106Xul17v2 2.183 2.183 0.000 ( +0.0% ) 5.60 5.69 -1.7% 2.820 2.809
2500.013_NANOdata106Xul18v2 1.998 1.998 0.000 ( +0.0% ) 7.97 7.89 +1.1% 2.726 2.712
2500.021_NANOmcUL16APVreMINI 0.022 0.022 -0.000 ( -0.2% ) 2.00 1.87 +6.6% 2.600 2.593
2500.022_NANOmcUL16reMINI 0.022 0.022 0.000 ( +0.0% ) 1.93 1.81 +6.8% 2.594 2.582
2500.023_NANOmcUL17reMINI 0.022 0.022 0.000 ( +0.2% ) 1.83 1.73 +6.2% 2.447 2.444
2500.024_NANOmcUL18reMINI 0.022 0.022 0.000 ( +0.0% ) 1.52 1.44 +5.4% 2.688 2.686
2500.031_NANOdataUL16APVreMINI 0.035 0.035 0.000 ( +0.0% ) 1.70 1.59 +7.0% 2.656 2.658
2500.032_NANOdataUL16reMINI 0.036 0.036 0.000 ( +0.0% ) 1.72 1.62 +6.0% 2.613 2.613
2500.033_NANOdataUL17reMINI 0.037 0.037 0.000 ( +0.0% ) 1.62 1.55 +4.6% 2.702 2.693
2500.034_NANOdataUL18reMINI 0.036 0.036 0.000 ( +0.0% ) 1.66 1.56 +6.3% 2.675 2.666
2500.101_NANOmc130X 2.801 2.801 0.000 ( +0.0% ) 16.57 15.41 +7.5% 2.624 2.619
2500.111_NANOdata130Xrun3 1.461 1.461 0.000 ( +0.0% ) 31.14 28.86 +7.9% 2.324 2.322
2500.112_NANOdata130Xrun3 1.881 1.881 0.000 ( +0.0% ) 26.19 23.50 +11.4% 2.405 2.402
2500.131_ScoutingNANOdata130Xrun3 0.747 0.747 0.000 ( +0.0% ) 37.60 34.85 +7.9% 1.514 1.499
2500.201_NANOmc140X 2.636 2.636 0.000 ( +0.0% ) 13.86 12.88 +7.5% 2.186 2.181
2500.211_NANOdata140Xrun3 1.804 1.804 0.000 ( +0.0% ) 27.72 24.78 +11.9% 2.403 2.394
2500.212_NANOdata140Xrun3 2.200 2.200 0.000 ( +0.0% ) 23.07 20.18 +14.3% 2.481 2.478
2500.221_muPOGNANOmc140X 2.036 2.036 0.000 ( +0.0% ) 14.85 13.75 +8.0% 2.107 2.100
2500.222_EGMNANOmc140X 3.437 3.437 0.000 ( +0.0% ) 13.78 12.56 +9.7% 2.204 2.196
2500.223_BTVNANOmc140X 9.403 9.403 0.000 ( +0.0% ) 4.24 3.97 +6.7% 2.273 2.268
2500.224_jmeNANOmc140X 6.259 6.259 0.000 ( +0.0% ) 1.38 1.32 +4.6% 2.220 2.254
2500.225_jmeNANOrePuppimc140X 6.306 6.306 0.000 ( +0.0% ) 1.28 1.23 +3.5% 2.432 2.469
2500.226_lepTrackInfoNANOmc140X 3.131 3.131 0.000 ( +0.0% ) 14.36 13.36 +7.4% 2.193 2.193
2500.227_ScoutingNANOmc140X 1.437 1.437 0.000 ( +0.0% ) 24.18 22.62 +6.9% 1.447 1.441
2500.231_muPOGNANO140Xrun3 1.454 1.454 0.000 ( +0.0% ) 23.27 21.01 +10.8% 2.285 2.282
2500.232_EGMNANOdata140Xrun3 2.459 2.459 0.000 ( +0.0% ) 21.44 19.44 +10.3% 2.393 2.392
2500.233_BTVNANOdata140Xrun3 4.952 4.952 0.000 ( +0.0% ) 6.21 5.79 +7.4% 2.465 2.454
2500.234_jmeNANOdata140Xrun3 3.838 3.838 0.000 ( +0.0% ) 1.72 1.69 +1.7% 2.178 2.429
2500.235_jmeNANOrePuppidata140Xrun3 3.869 3.869 0.000 ( +0.0% ) 1.59 1.58 +0.7% 2.380 2.619
2500.236_lepTrackInfoNANOdata140Xrun3 2.249 2.249 0.000 ( +0.0% ) 23.27 21.15 +10.0% 2.391 2.387
2500.237_ScoutingNANOdata140Xrun3 1.016 1.016 0.000 ( +0.0% ) 34.87 32.85 +6.2% 1.452 1.464
2500.241_l1DPGNANO140Xrun3 9.404 9.404 0.000 ( +0.0% ) 7.39 6.90 +7.1% 1.924 1.915
2500.242_muDPGNANO140Xrun3 10.331 10.331 0.000 ( +0.0% ) 1.58 1.57 +0.5% 1.718 1.712
2500.243_muDPGNANOBkg140Xrun3 2.712 2.712 0.000 ( +0.0% ) 16.84 15.75 +6.9% 1.077 1.075
2500.244_hcalDPGNANO140Xrun3 485.976 485.976 0.000 ( +0.0% ) 1.13 1.09 +3.3% 1.691 1.686
2500.245_hcalDPGCalibNANO140Xrun3 823.202 823.202 0.000 ( +0.0% ) 1.49 1.41 +5.8% 1.687 1.675
2500.901_TTbarMINIAOD10.6_UL18v2 1.777 1.777 0.000 ( +0.0% ) 47.62 45.39 +4.9% 1.423 1.417
2500.902_TTbarMINIAOD14.0 1.627 1.627 0.000 ( +0.0% ) 47.73 45.52 +4.9% 1.089 1.321
2500.911_DYToLL_M-50_13TeV_pythia8 14.041 14.041 0.000 ( +0.0% ) 8.76 8.31 +5.3% 1.087 1.087
2500.912_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 0.729 0.171 0.559 ( +327.7% ) 3.73 2.62 +42.4% 0.968 0.975
2500.913_TTbar_Pow_LHE_13TeV 0.110 0.110 0.000 ( +0.0% ) 2.55 2.26 +13.1% 0.980 0.977

NANO Comparison Summary

Summary:

  • You potentially added 150 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 74922
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 74922
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

@ftorrresd
Copy link
Contributor

+1

@Moanwar
Copy link
Contributor

Moanwar commented Oct 8, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants