Skip to content

Conversation

@winterchristian
Copy link
Contributor

PR description:

This is a backport for #47299 and #48408. It's similar to the backports #49290 (14_0_X), #49022 (14_2_X), #48557 (15_0_X) and #49039 (15_1_X).
This backport only serves to complete the line of backports since 14_0_X.

PR validation:

Unit tests and release validations (136.901,136.902,136.903,136.904,136.905,136.906) are implemented.

Christian Winter and others added 2 commits November 18, 2025 18:50
Embedding update for run3

(cherry picked from commit afa07e5)
…_0_pre1_improveCode

Restructure and comment the tau embedding method

(cherry picked from commit 1cf5c12)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @winterchristian for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/Applications (operations)
  • Configuration/EventContent (operations)
  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (pdmv)
  • Configuration/StandardSequences (operations)
  • IOMC/EventVertexGenerators (simulation)
  • PhysicsTools/NanoAOD (xpog)
  • RecoLocalCalo/Configuration (reconstruction)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • RecoLocalCalo/HcalRecProducers (reconstruction)
  • RecoLocalMuon/CSCRecHitD (reconstruction)
  • RecoLocalMuon/CSCSegment (reconstruction)
  • RecoLocalMuon/DTRecHit (reconstruction)
  • RecoLocalMuon/DTSegment (reconstruction)
  • RecoLocalMuon/RPCRecHit (reconstruction)
  • RecoLocalTracker/SiStripClusterizer (reconstruction)
  • RecoLuminosity/LumiProducer (reconstruction)
  • RecoTracker/IterativeTracking (reconstruction)
  • RecoVertex/Configuration (reconstruction)
  • SimGeneral/MixingModule (simulation)
  • TauAnalysis/MCEmbeddingTools (simulation)

@AdrianoDee, @DickyChant, @antoniovagnerini, @battibass, @civanch, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @ftorrresd, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @srimanob can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @Martin-Grunewald, @ReyerBand, @VinInn, @VourMa, @abbiendi, @abdoulline, @alesaggio, @apsallid, @argiro, @battibass, @bellan, @bsunanda, @denizsun, @dgulhan, @echabert, @elusian, @fabiocos, @felicepantaleo, @gbenelli, @gpetruc, @grzanka, @jhgoh, @jlidrych, @makortel, @mariadalfonso, @martinamalberti, @missirol, @mmasciov, @mmusich, @mtosi, @ptcox, @rchatter, @robervalwalsh, @rovere, @salimcerci, @sameasy, @slomeo, @thomreis, @threus, @wang0jin, @yduhm, @youyingli this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2025

cms-bot internal usage

@AdrianoDee
Copy link
Contributor

please test workflows 136.901,136.902,136.903,136.904,136.905,136.906)

@AdrianoDee
Copy link
Contributor

please abort

@AdrianoDee
Copy link
Contributor

code-checks

@AdrianoDee
Copy link
Contributor

please test workflows 136.901,136.902,136.903,136.904,136.905,136.906

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals AddOn
Size: This PR adds an extra 1856KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5aaad/49537/summary.html
COMMIT: 53fcbe0
CMSSW: CMSSW_14_1_X_2025-11-16-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49410/49537/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 32 errors in the following unit tests:

---> test TestDQMOnlineClient-csc_dqm_sourceclient had ERRORS
---> test testTauEmbeddingWorkflow2022postEE had ERRORS
---> test testTauEmbeddingWorkflow2016postVFP had ERRORS
and more ...

Failed RelVals

  • 136.903136.903_RunDoubleMuon2017B/step2_RunDoubleMuon2017B.log
  • 135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
  • 332.0332.0_Pyquen_ZeemumuJets_pt10_5362GeV_2024/step3_Pyquen_ZeemumuJets_pt10_5362GeV_2024.log
Expand to see more relval errors ...

Failed AddOn Tests

UNKNOWN
UNKNOWN
UNKNOWN
Expand to see more addon errors ...

@cmsbuild
Copy link
Contributor

@winterchristian
Copy link
Contributor Author

Sorry for the failing tests. I forgot that I have to include changes because the SwitchProducerCUDA are still there in the older branches. Should work now

@ftorrresd
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5aaad/49650/summary.html
COMMIT: 337d351
CMSSW: CMSSW_14_1_X_2025-11-23-0000/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49410/49650/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001_NANOmc106Xul16v2 2.791 2.791 0.000 ( +0.0% ) 7.68 7.56 +1.5% 2.176 2.320
2500.002_NANOmc106Xul17v2 2.903 2.903 0.000 ( +0.0% ) 6.78 6.72 +0.9% 2.602 2.757
2500.003_NANOmc106Xul18v2 2.851 2.851 0.000 ( +0.0% ) 7.01 7.01 +0.0% 2.589 2.731
2500.011_NANOdata106Xul16v2 1.456 1.456 0.000 ( +0.0% ) 13.40 13.06 +2.6% 2.274 2.422
2500.012_NANOdata106Xul17v2 1.914 1.914 0.000 ( +0.0% ) 7.24 7.12 +1.6% 2.426 2.618
2500.013_NANOdata106Xul18v2 1.770 1.770 0.000 ( +0.0% ) 10.59 10.40 +1.8% 2.345 2.517
2500.021_NANOmcUL16APVreMINI 0.022 0.022 0.000 ( +0.0% ) 2.03 2.02 +0.6% 2.265 2.485
2500.022_NANOmcUL16reMINI 0.022 0.022 0.000 ( +0.0% ) 2.00 1.99 +0.4% 2.269 2.479
2500.023_NANOmcUL17reMINI 0.022 0.022 0.000 ( +0.0% ) 1.98 1.91 +3.3% 2.218 2.340
2500.024_NANOmcUL18reMINI 0.022 0.022 0.000 ( +0.0% ) 1.53 1.53 +0.4% 2.387 2.585
2500.031_NANOdataUL16APVreMINI 0.035 0.035 0.000 ( +0.0% ) 1.77 1.85 -4.1% 2.375 2.565
2500.032_NANOdataUL16reMINI 0.036 0.036 0.000 ( +0.0% ) 1.94 1.90 +2.5% 2.302 2.518
2500.033_NANOdataUL17reMINI 0.037 0.037 0.000 ( +0.1% ) 1.72 1.65 +4.2% 2.407 2.611
2500.034_NANOdataUL18reMINI 0.036 0.036 0.000 ( +0.0% ) 1.74 1.76 -1.1% 2.393 2.586
2500.101_NANOmc130X 2.643 2.643 0.000 ( +0.0% ) 21.54 20.79 +3.6% 2.329 2.481
2500.111_NANOdata130Xrun3 1.339 1.339 0.000 ( +0.0% ) 49.52 46.55 +6.4% 2.070 2.187
2500.112_NANOdata130Xrun3 1.745 1.745 0.000 ( +0.0% ) 37.96 34.78 +9.1% 2.079 2.277
2500.131_ScoutingNANOdata130Xrun3 0.747 0.747 0.000 ( +0.0% ) 37.74 36.86 +2.4% 1.366 1.497
2500.201_NANOmc140X 2.478 2.478 0.000 ( +0.0% ) 17.71 16.70 +6.0% 1.920 2.063
2500.211_NANOdata140Xrun3 1.592 1.592 0.000 ( +0.0% ) 44.83 41.48 +8.1% 2.061 2.278
2500.212_NANOdata140Xrun3 2.033 2.033 0.000 ( +0.0% ) 33.08 29.51 +12.1% 2.105 2.360
2500.221_muPOGNANOmc140X 2.006 2.006 0.000 ( +0.0% ) 19.16 18.88 +1.5% 1.784 1.981
2500.222_EGMNANOmc140X 3.140 3.140 0.000 ( +0.0% ) 17.57 16.99 +3.4% 1.839 2.071
2500.223_BTVNANOmc140X 8.888 8.888 0.000 ( +0.0% ) 6.80 6.71 +1.3% 1.859 2.096
2500.224_jmeNANOmc140X 5.515 5.515 0.000 ( +0.0% ) 2.74 2.70 +1.4% 1.913 2.121
2500.225_jmeNANOrePuppimc140X 5.533 5.533 0.000 ( +0.0% ) 2.49 2.44 +1.9% 1.943 2.148
2500.226_lepTrackInfoNANOmc140X 2.973 2.973 0.000 ( +0.0% ) 18.45 18.08 +2.1% 1.831 2.067
2500.227_ScoutingNANOmc140X 1.437 1.437 0.000 ( +0.0% ) 24.21 23.65 +2.4% 1.299 1.433
2500.231_muPOGNANO140Xrun3 1.407 1.407 0.000 ( +0.0% ) 34.23 32.93 +3.9% 1.937 2.164
2500.232_EGMNANOdata140Xrun3 2.199 2.199 0.000 ( +0.0% ) 30.76 30.65 +0.3% 2.003 2.262
2500.233_BTVNANOdata140Xrun3 4.671 4.671 0.000 ( +0.0% ) 11.75 11.57 +1.6% 2.017 2.280
2500.234_jmeNANOdata140Xrun3 3.307 3.307 0.000 ( +0.0% ) 3.84 3.75 +2.4% 2.046 2.305
2500.235_jmeNANOrePuppidata140Xrun3 3.317 3.317 0.000 ( +0.0% ) 3.46 3.39 +2.0% 2.086 2.319
2500.236_lepTrackInfoNANOdata140Xrun3 2.085 2.085 0.000 ( +0.0% ) 32.89 32.49 +1.2% 2.001 2.260
2500.237_ScoutingNANOdata140Xrun3 1.016 1.016 0.000 ( +0.0% ) 35.83 34.62 +3.5% 1.320 1.464
2500.241_l1DPGNANO140Xrun3 9.404 9.404 0.000 ( +0.0% ) 2.65 6.99 -62.1% 1.771 1.925
2500.242_muDPGNANO140Xrun3 10.331 10.331 0.000 ( +0.0% ) 1.64 1.50 +9.6% 1.609 1.701
2500.243_muDPGNANOBkg140Xrun3 2.712 2.712 0.000 ( +0.0% ) 16.37 14.85 +10.3% 1.012 1.057
2500.244_hcalDPGNANO140Xrun3 485.976 485.976 0.000 ( +0.0% ) 1.15 1.13 +2.0% 1.553 1.696
2500.245_hcalDPGCalibNANO140Xrun3 823.202 823.202 0.000 ( +0.0% ) 1.51 1.46 +3.6% 1.534 1.679
2500.901_TTbarMINIAOD10.6_UL18v2 1.749 1.749 0.000 ( +0.0% ) 49.39 45.53 +8.5% 1.368 1.406
2500.902_TTbarMINIAOD14.0 1.598 1.598 0.000 ( +0.0% ) 51.38 49.46 +3.9% 1.260 1.312
2500.911_DYToLL_M-50_13TeV_pythia8 13.931 13.931 0.000 ( +0.0% ) 6.94 7.36 -5.7% 1.024 1.076
2500.912_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 0.437 0.310 0.126 ( +40.7% ) 2.07 3.25 -36.3% 0.970 0.963
2500.913_TTbar_Pow_LHE_13TeV 0.110 0.110 0.000 ( +0.0% ) 2.60 2.53 +2.5% 0.979 0.969

NANO Comparison Summary

Summary:

@ftorrresd
Copy link
Contributor

+xpog

@AdrianoDee
Copy link
Contributor

please test

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5aaad/50330/summary.html
COMMIT: 337d351
CMSSW: CMSSW_14_1_X_2025-12-14-0000/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49410/50330/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3672688
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3672662
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 203 log files, 174 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001_NANOmc106Xul16v2 2.791 2.791 0.000 ( +0.0% ) 7.63 6.04 +26.4% 2.143 2.315
2500.002_NANOmc106Xul17v2 2.903 2.903 0.000 ( +0.0% ) 6.78 5.50 +23.3% 2.566 2.748
2500.003_NANOmc106Xul18v2 2.851 2.851 0.000 ( +0.0% ) 7.06 5.67 +24.7% 2.565 2.729
2500.011_NANOdata106Xul16v2 1.456 1.456 0.000 ( +0.0% ) 13.18 10.43 +26.3% 2.258 2.408
2500.012_NANOdata106Xul17v2 1.914 1.914 0.000 ( +0.0% ) 7.17 5.75 +24.8% 2.398 2.607
2500.013_NANOdata106Xul18v2 1.770 1.770 0.000 ( +0.0% ) 10.54 8.18 +28.9% 2.344 2.511
2500.021_NANOmcUL16APVreMINI 0.022 0.022 0.000 ( +0.0% ) 1.97 1.48 +32.8% 2.276 2.480
2500.022_NANOmcUL16reMINI 0.022 0.022 0.000 ( +0.0% ) 1.92 1.57 +22.2% 2.267 2.478
2500.023_NANOmcUL17reMINI 0.022 0.022 0.000 ( +0.0% ) 1.99 1.48 +34.3% 2.212 2.346
2500.024_NANOmcUL18reMINI 0.022 0.022 0.000 ( +0.0% ) 1.53 1.13 +35.7% 2.382 2.578
2500.031_NANOdataUL16APVreMINI 0.035 0.035 0.000 ( +0.0% ) 1.80 1.35 +33.5% 2.374 2.567
2500.032_NANOdataUL16reMINI 0.036 0.036 0.000 ( +0.0% ) 1.93 1.39 +39.0% 2.304 2.508
2500.033_NANOdataUL17reMINI 0.037 0.037 -0.000 ( -0.1% ) 1.72 1.30 +31.9% 2.410 2.596
2500.034_NANOdataUL18reMINI 0.036 0.036 0.000 ( +0.0% ) 1.74 1.30 +34.3% 2.392 2.589
2500.101_NANOmc130X 2.643 2.643 0.000 ( +0.0% ) 21.77 16.08 +35.4% 2.301 2.482
2500.111_NANOdata130Xrun3 1.339 1.339 0.000 ( +0.0% ) 49.46 33.87 +46.0% 2.036 2.188
2500.112_NANOdata130Xrun3 1.745 1.745 0.000 ( +0.0% ) 36.30 26.17 +38.7% 2.077 2.280
2500.131_ScoutingNANOdata130Xrun3 0.747 0.747 0.000 ( +0.0% ) 37.24 29.78 +25.1% 1.365 1.502
2500.201_NANOmc140X 2.478 2.478 0.000 ( +0.0% ) 17.77 13.18 +34.8% 1.928 2.057
2500.211_NANOdata140Xrun3 1.592 1.592 0.000 ( +0.0% ) 44.33 30.29 +46.4% 2.060 2.276
2500.212_NANOdata140Xrun3 2.033 2.033 0.000 ( +0.0% ) 32.75 19.77 +65.7% 2.100 2.360
2500.221_muPOGNANOmc140X 2.006 2.006 0.000 ( +0.0% ) 18.72 14.03 +33.4% 1.774 1.985
2500.222_EGMNANOmc140X 3.140 3.140 0.000 ( +0.0% ) 17.39 13.40 +29.7% 1.837 2.072
2500.223_BTVNANOmc140X 8.888 8.888 0.000 ( +0.0% ) 6.82 5.22 +30.7% 1.864 2.099
2500.224_jmeNANOmc140X 5.515 5.515 0.000 ( +0.0% ) 2.74 2.20 +24.9% 1.904 2.125
2500.225_jmeNANOrePuppimc140X 5.533 5.533 0.000 ( +0.0% ) 2.47 1.97 +25.6% 1.916 2.152
2500.226_lepTrackInfoNANOmc140X 2.973 2.973 0.000 ( +0.0% ) 18.31 13.60 +34.6% 1.832 2.062
2500.227_ScoutingNANOmc140X 1.437 1.437 0.000 ( +0.0% ) 24.05 19.53 +23.1% 1.307 1.429
2500.231_muPOGNANO140Xrun3 1.407 1.407 0.000 ( +0.0% ) 33.74 22.62 +49.1% 1.937 2.171
2500.232_EGMNANOdata140Xrun3 2.199 2.199 0.000 ( +0.0% ) 30.40 23.11 +31.6% 2.005 2.269
2500.233_BTVNANOdata140Xrun3 4.671 4.671 0.000 ( +0.0% ) 11.66 9.02 +29.3% 2.015 2.276
2500.234_jmeNANOdata140Xrun3 3.307 3.307 0.000 ( +0.0% ) 3.79 3.10 +22.3% 2.044 2.302
2500.235_jmeNANOrePuppidata140Xrun3 3.317 3.317 0.000 ( +0.0% ) 3.45 2.79 +23.8% 2.086 2.323
2500.236_lepTrackInfoNANOdata140Xrun3 2.085 2.085 0.000 ( +0.0% ) 32.72 23.91 +36.8% 1.999 2.259
2500.237_ScoutingNANOdata140Xrun3 1.016 1.016 0.000 ( +0.0% ) 35.45 29.07 +21.9% 1.322 1.456
2500.241_l1DPGNANO140Xrun3 9.404 9.404 0.000 ( +0.0% ) 7.30 5.11 +42.9% 1.772 1.917
2500.242_muDPGNANO140Xrun3 10.331 10.331 0.000 ( +0.0% ) 1.64 1.34 +22.8% 1.645 1.697
2500.243_muDPGNANOBkg140Xrun3 2.712 2.712 0.000 ( +0.0% ) 15.64 11.15 +40.2% 1.003 1.060
2500.244_hcalDPGNANO140Xrun3 485.976 485.976 0.000 ( +0.0% ) 1.14 0.96 +19.0% 1.569 1.671
2500.245_hcalDPGCalibNANO140Xrun3 823.202 823.202 0.000 ( +0.0% ) 1.52 1.20 +26.6% 1.542 1.680
2500.901_TTbarMINIAOD10.6_UL18v2 1.749 1.749 0.000 ( +0.0% ) 48.32 32.43 +49.0% 1.334 1.405
2500.902_TTbarMINIAOD14.0 1.598 1.598 0.000 ( +0.0% ) 50.78 40.02 +26.9% 1.285 1.310
2500.911_DYToLL_M-50_13TeV_pythia8 13.931 13.931 0.000 ( +0.0% ) 7.45 4.78 +55.8% 1.023 1.074
2500.912_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 0.729 0.437 0.293 ( +67.1% ) 2.74 3.27 -16.4% 0.965 0.965
2500.913_TTbar_Pow_LHE_13TeV 0.110 0.110 0.000 ( +0.0% ) 2.58 2.21 +16.9% 0.976 0.972

NANO Comparison Summary

Summary:

  • You potentially added 29 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 54921
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 54921
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Dec 18, 2025

The error is clearly unrelated (it's an X509 certificate error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants