-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[14_1_X] Backport: Restructure and comment the tau embedding method #49410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: CMSSW_14_1_X
Are you sure you want to change the base?
[14_1_X] Backport: Restructure and comment the tau embedding method #49410
Conversation
|
A new Pull Request was created by @winterchristian for CMSSW_14_1_X. It involves the following packages:
@AdrianoDee, @DickyChant, @antoniovagnerini, @battibass, @civanch, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @ftorrresd, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
cms-bot internal usage |
|
please test workflows 136.901,136.902,136.903,136.904,136.905,136.906) |
|
please abort |
|
code-checks |
|
please test workflows 136.901,136.902,136.903,136.904,136.905,136.906 |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49410/46871 |
|
-1 Failed Tests: UnitTests RelVals AddOn Failed Unit TestsI found 32 errors in the following unit tests: ---> test TestDQMOnlineClient-csc_dqm_sourceclient had ERRORS ---> test testTauEmbeddingWorkflow2022postEE had ERRORS ---> test testTauEmbeddingWorkflow2016postVFP had ERRORS and more ... Failed RelVals
Expand to see more relval errors ...
Failed AddOn TestsExpand to see more addon errors ... |
|
Pull request #49410 was updated. @AdrianoDee, @DickyChant, @antoniovagnerini, @battibass, @civanch, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @ftorrresd, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @srimanob can you please check and sign again. |
|
Sorry for the failing tests. I forgot that I have to include changes because the |
|
please test |
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
|
+xpog |
|
please test |
|
+pdmv |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Failed Tests: UnitTests Failed Unit TestsI found 1 errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
|
The error is clearly unrelated (it's an X509 certificate error). |
PR description:
This is a backport for #47299 and #48408. It's similar to the backports #49290 (14_0_X), #49022 (14_2_X), #48557 (15_0_X) and #49039 (15_1_X).
This backport only serves to complete the line of backports since 14_0_X.
PR validation:
Unit tests and release validations (136.901,136.902,136.903,136.904,136.905,136.906) are implemented.