[15_1_X] Backport tau embedding changes for 2025production #49039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a26aa7d)
(cherry picked from commit 1ca62c9)
(cherry picked from commit 030bd7c)
…cmsDriver HLT step (cherry picked from commit 96339e1)
…mbedding table (cherry picked from commit ddce945)
…naming (cherry picked from commit 4004609)
…the past (cherry picked from commit 4ab37ff)
(cherry picked from commit c5586ea)
(cherry picked from commit 52d113d)
(cherry picked from commit 127d1b4)
(cherry picked from commit 47c21fc)
(cherry picked from commit b8725c6)
(cherry picked from commit 0b343c5)
(cherry picked from commit 81db7b4)
(cherry picked from commit e80d83d)
* add special tau embedding EventContents * add NANOAOD to NanoAOD event content name to be handled properly * adapt eventcontent in cmsDriver commands --------- Co-authored-by: Christian Winter <[email protected]> (cherry picked from commit 7650c60)
(cherry picked from commit e673930)
(cherry picked from commit 08a6ba2)
(cherry picked from commit 3add164)
(cherry picked from commit fa50856)
(cherry picked from commit 6452987)
* first try distributing process Modifiers of Cleaning step * disable finale state radiation for mu->mu embedding * update center of mass energy for run3 * implement correct ModifierChain for tau embedding process modifiers * revert some changes * set all process modifier for tau embeddign cleaning step * Introduce special cleaning and simulation process modifier * add process modifiers for sim gen step * Set process modifiers for reco sim step * add process modifier for tau embedding merging step Those "toReplaceWith" modifiers need to be applied as late as possible e.g. in StandardSequences.Reconstruction_Data_cff. This is to avoid collisions with other modules that are cloned and modified versions from the original modules or "toModify" modifier calls that try to modify the original modules. They throw an exeption if they want to do this on the replaced merger modules. * add autoNANO option for the tau embedding nanoaod files * adjust test cmsDriver commands to work with the new process modifiers --------- Co-authored-by: Christian Winter <[email protected]> (cherry picked from commit 164e69d)
(cherry picked from commit 2993c3e)
Contributor
|
+1 |
Contributor
|
enable nano |
Contributor
|
please test |
cmsbuild
added
operations-pending
tests-started
and removed
operations-approved
tests-approved
labels
Contributor
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
Nano size comparison Summary:
NANO Comparison SummarySummary:
|
cmsbuild
added
operations-approved
tests-approved
and removed
operations-pending
tests-started
labels
Contributor
|
+1 |
Contributor
|
+Upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This is a backport for #48408. It's similar to the backports #49022 (
14_2_X) and #48557 (15_0_X).PR validation:
Unit tests and release validations (136.901,136.902,136.903,136.904,136.905,136.906) are implemented and tested.