-
Notifications
You must be signed in to change notification settings - Fork 271
Demo 2 Quarto notebook tutorial for PEcAn uncertainty analysis #3570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Demo 2 Quarto notebook tutorial for PEcAn uncertainty analysis #3570
Conversation
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
7033438 to
122ef77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, it is off to a great start and it is clear that you have a good understanding of how these analyses work.
I've started reviewing the notebook and have a few suggestions for how and what information is presented - I think it will be most effective if I flesh out some of the more technical details, and determine what information can be provided as cross references to publications vs what should be explained here.
But I'd also like to request some changes from the workflow side. Many of these are changes to Demo 1 that I suggested (AritraDey-Dev#6), and I think these should be reflected in this repository.
Some specific changes that come to mind:
- eliminate hard coded paths like /pecan and /data
- use R's
file.copy()function in place ofsystem('cp ...) - don't assume user will be running in Docker with local binaries and absolute paths pre-installed
- the only difference between the pecan.xml files should be related to uncertainty / ensemble / sensitivity analysis. File paths and other settings should be the same. This helps clarify and identify the meaningful changes that are necessary.
- Make directory naming consistent - not clear why there is 01_Demo_basic_run, 02_Demo_Uncertainty_Analysis, and Demo_02_Uncertainty_Analysis.
These changes should help keep the tutorial easier to understand and maintain. Let me know if you’d like help implementing them—happy to pair on a walkthrough or review the follow-up PR. Thanks!
|
Yes, once the Demo 1 PR gets merged, I’ll add the changes you mentioned above here. |
12f7e60 to
b9cb3bf
Compare
documentation/tutorials/Demo_02_Uncertainty_Analysis/uncertainty.qmd
Outdated
Show resolved
Hide resolved
|
Great work getting Demo 1 in #3531 merged 🎉 — that’s a big milestone! Now that that one is merged, there is still a fair bit of cleanup to do here, and it will require updating Demo 1 as well. It’s all very doable, and I think the payoff will be a much more polished and user-friendly Demo 2. Here are some steps:
This is very close! While this is still a bit of work, it’s mostly structural and editorial / pedagogical. Once you have successfully merged the branches, consolidated the background, and made sure that all information from the original Demo 2 is in the new version, I can take a final pass at the writing. |
documentation/tutorials/Demo_02_Uncertainty_Analysis/uncertainty.qmd
Outdated
Show resolved
Hide resolved
8d965d1 to
cfface8
Compare
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
8501d25 to
1f9f0a2
Compare
Signed-off-by: Aritra Dey <[email protected]>
… / expand on key concepts in uncertainty analysis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AritraDey-Dev thank you for this!
I've made some major edits in AritraDey-Dev#7. Please review and let me know if I have changed the intent. The goal was to make it more clear and remove some explanations that had been covered in Demo 1.
I'll approve this one once that is merged.
Signed-off-by: Aritra Dey <[email protected]>
|
@dlebauer are there any changes needed from your side, or is this PR ready to be merged? |
|
Please cross reference with the original demo2 to make sure that the new one has all of the pedagogical content. Or, I can do that Monday. |
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
Migrating additional content from UI demos to Quarto demos
Signed-off-by: Aritra Dey <[email protected]>
Signed-off-by: Aritra Dey <[email protected]>
| legend("topright", legend = c("LAI", "Above Ground Wood"), col = c("darkgreen", "brown"), lty = 1) | ||
| ``` | ||
|
|
||
| # 18. PEcAn Outputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is almost same as section 9 which tells about pecan outputs,also in this part as it mentions trait and meta analysis which we are not doing in this notebook,so can we remove this part @dlebauer ?
Description
Added a Quarto notebook tutorial for PEcAn uncertainty analysis (uncertainty.qmd) that demonstrates ensemble and sensitivity analysis workflows. The tutorial includes:
Motivation and Context
This change introduces Demo2 for the Quarto notebook focused on uncertainty analysis. It serves as a continuation and enhancement of the work initiated in Demo1. The goal is to extend the functionality and provide a more comprehensive demonstration of uncertainty analysis within the PEcAn framework.
Review Time Estimate
Types of changes
Checklist: