Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slime People and IPC; Imitating Species Cosmetically. #27359

Conversation

Spaghetti-bit
Copy link
Contributor

@Spaghetti-bit Spaghetti-bit commented Nov 14, 2024

What Does This PR Do

Allows slime people and IPCs to imitate other species. This provides no mechanical benefit, and is purely cosmetic.

Slime People:

  • Round-Start / loadout species 'sub-type'.
  • In-Round changing of sub type by using an action and standing still for 10 seconds, costs the same as regenerating a limb.

IPC:

  • Round-Start / loadout species 'sub-type'.
  • In-Round changing via identity configuration surgery

LATER DOWN THE ROAD: ( I just need sprites 😭 )

  • Species specific augmentation / cybernetic limbs.

Why It's Good For The Game

More customization on top of more chances for disguises. Also allows for more diverse characters.

Images of changes

Slime imitation of a nian
image
Slime imitation of a unathi
image

IPC imitation of a vox and unathi
image

Testing

Lots of spawning in as the above species and changing 'sub-types'.
DB sql tested.
Link processing tested.
Morph form tested.
Identity configuration tested.
image


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image

Changelog

🆑
add: Added the ability for IPCs to imitate other species. This can be accessed via the character creator menu or in game via robotics surgery.
add: Added the ability for Slime People to imitate other species. This can be done via the character creator menu or in game via the 'morph form' action which requires the slime person to stand still for 10 seconds before being allowed to choose a new species to imitate, costs the same as regenerating a limb.
/:cl:

Sorry, something went wrong.

@AffectedArc07
Copy link
Member

In round changing sounds terrifying from a balance POV.

Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First tiny pass

code/__DEFINES/flags.dm Show resolved Hide resolved
code/modules/client/preference/character.dm Show resolved Hide resolved
@SynthTwo
Copy link
Contributor

!wiki_label

@github-actions github-actions bot added Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Merge Conflict This PR is merge conflicted labels Nov 14, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally SQL Change This PR modifies the game database. This PR must go through the host. Configuration Change This PR changes the game configuration files. Please run via the host. labels Nov 14, 2024
@Adrer Adrer added the Feature This PR is a new addition to the game label Nov 15, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Nov 15, 2024
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to update code\modules\client\login_processing\20-load_characters.dm

@Spaghetti-bit
Copy link
Contributor Author

Ready for review.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Feb 8, 2025
Signed-off-by: Spaghetti-bit <yumyumkillkill@gmail.com>
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make changes in the SQL/paradise_schema.sql master file as well.

@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Feb 8, 2025
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Feb 8, 2025
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the column 7 characters will only fit vulpkanin.

You did test this against a database right?

I will apologise for the mistesting accusation knowing that the 3 applicable species are less than 7 characters, however we should still allocate to 45 for futureproofing.

SQL/paradise_schema.sql Outdated Show resolved Hide resolved
SQL/updates/63-64.sql Outdated Show resolved Hide resolved
Co-authored-by: AffectedArc07 <25063394+AffectedArc07@users.noreply.github.com>
Signed-off-by: Spaghetti-bit <yumyumkillkill@gmail.com>
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIWB

@AffectedArc07 AffectedArc07 added this pull request to the merge queue Feb 9, 2025
Merged via the queue into ParadiseSS13:master with commit 32c9d4d Feb 9, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Configuration Change This PR changes the game configuration files. Please run via the host. Feature This PR is a new addition to the game Requires Wiki Update Useful for Wiki Contributers to search for things that need updating SQL Change This PR modifies the game database. This PR must go through the host. Stale Exempt This topic is exempt from becoming stale... Must have bribed a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants