-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message versioning and translation for ROS #24113
Conversation
🔎 FLASH Analysispx4_fmu-v5x [Total VM Diff: 152 byte (0.01 %)]
px4_fmu-v6x [Total VM Diff: 144 byte (0.01 %)]
Updated: 2025-02-05T10:33:52 |
6a3bb95
to
ef7c759
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised, this is awesome 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i left a few nitpicky comments regarding CI @bkueng, overall great work
This adds "_v" + string(T::MESSAGE_VERSION) to the ROS topic if the message contains a MESSAGE_VERSION field (and the version is non-zero).
ef7c759
to
1b92445
Compare
6eea223
to
dc4dd9d
Compare
dc4dd9d
to
0115a0b
Compare
Thanks for all the reviews and tests. This is getting ready. |
@mrpollo good to go from your side? |
Good to go |
Follow-up to #23850
I ended up adding a script that copies the translation node and msg files into a ROS workspace. I tested an approach of directly adding PX4 into a workspace, but ran into too many issues (e.g. msg namespace cannot be customized independently, or that there cannot be multiple subprojects if the toplevel directory already contains a CMakeLists.txt).