fix(perception): publish bbox width/height, not full-image dims - #501
Open
shreyjoshi2004 wants to merge 1 commit into
Open
fix(perception): publish bbox width/height, not full-image dims#501shreyjoshi2004 wants to merge 1 commit into
shreyjoshi2004 wants to merge 1 commit into
Conversation
3 tasks
The image-shape unpack shadowed the YOLO bbox width/height, so every PedestrianInfo carried the full image dimensions. Rename the image-shape locals to img_h/img_w so they no longer clobber the bbox dims. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
shreyjoshi2004
force-pushed
the
fix_pedestrian_bbox_dims
branch
from
June 13, 2026 20:46
1c58bd6 to
a5fa68a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside
detect_pedestrians(), the image-shape unpackheight, width, channels = self.image.shapeclobbered the YOLO bboxwidth/height, so everyPedestrianInfocarried the full image dimensions instead of the bbox dimensions. Renamed those locals toimg_h/img_wso they no longer shadow the bbox dims.PedestrianInfohas no consumers yet, so this changes no live behavior.