Add jedi-ci to CRTMv3 #242
Conversation
|
This is coming along well, it still depends on a jedi-ci branch that will need review, but the action successfully builds and runs this repository. I've triggered a fresh build now; the prior build was successful but failed at the end because I hadn't set up a CDash project to receive the results. |
Swap jedi-ci action branch back to deveop now that JCSDA-internal/jedi-ci#21 is merged
| on: | ||
| pull_request: | ||
| branches: | ||
| - 'master' |
There was a problem hiding this comment.
We don't use master or main branches.
There was a problem hiding this comment.
Just casting a broad net here. This clause is the same on all repos which also makes global changes (which require scripted github interactions) a little easier.
| with: | ||
| container_version: latest | ||
| target_project_name: crtm | ||
| test_dependencies: ioda oops gsw ufo-data ufo |
There was a problem hiding this comment.
I don't understand the list of dependencies here, it looks either too long (if it's just for crtm) or too short (if it's for the bundle). What is it supposed to be dependencies for?
There was a problem hiding this comment.
@eap following up on Yannick's comment, what do these dependencies do?
There was a problem hiding this comment.
These are the end-to-end test dependencies (upstream and downstream) needed to build and run CRTM tests using the jedi bundle. Taken from Ben's comment here
There was a problem hiding this comment.
I still don't see what it's supposed to be. If we want all the downstream repos, there should be a lot more. If it's just upstream there should be less. From the comment above, it's upstream and downstream, so the list should include all the model repos where crtm is used.
Add jedi-ci to CRTMv3 using the new jedi-ci GitHub action.
As a side note. I'd like to point out that CRTMv3 was the straw that broke the camel's back for the old CI. I knew CI needed an overhaul as soon as the paint was dry, but the deep technical debt resulting in the total infeasibility of supporting CRTM was the final motivation I needed to fix it. Issue 165 in jcsda-internal/CI has been sitting like a rock in my shoe for almost 6 months and I'm just gald to see the finish line.
Issue(s) addressed
Issue: JCSDA-internal/jedi-ci#26 - jedi-ci-action rollout continued: models and new integrations
Resolves: https://github.com/JCSDA-internal/CI/issues/165 - Add CI testing to CRTM
Checklist