-
Notifications
You must be signed in to change notification settings - Fork 17
Add jedi-ci to CRTMv3 #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
fda85bf
7d836dc
e718718
b052515
6cc7ed5
8dc3e23
0371f94
b5f6d4c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
name: start-jedi-ci | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- 'master' | ||
- 'main' | ||
- 'develop' | ||
|
||
jobs: | ||
launch-tests: | ||
runs-on: ubuntu-latest | ||
permissions: | ||
id-token: write | ||
contents: read | ||
steps: | ||
|
||
- name: Generate CI App token | ||
id: generate-token | ||
uses: actions/create-github-app-token@v1 | ||
with: | ||
# Owner is specified to scope the token to the org install | ||
# otherwise the token will be scoped to the repository. | ||
app-id: 321361 | ||
private-key: ${{ secrets.CI_APP_PRIVATE_KEY }} | ||
owner: JCSDA | ||
|
||
- name: checkout repository | ||
uses: actions/checkout@v4 | ||
with: | ||
path: target_repository | ||
|
||
- name: Configure AWS credentials | ||
uses: aws-actions/configure-aws-credentials@v4 | ||
with: | ||
# This role only has the permission to write to our lfs archive s3 bucket path. | ||
role-to-assume: arn:aws:iam::747101682576:role/service-role/jedi-ci-action-runner-backend-GitHubActionsIAMRole-HkHdJRVEFw3x | ||
aws-region: us-east-2 | ||
|
||
- name: Run JEDI CI | ||
uses: JCSDA-internal/jedi-ci@develop | ||
with: | ||
container_version: latest | ||
target_project_name: crtm | ||
test_dependencies: ioda oops gsw ufo-data ufo | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't understand the list of dependencies here, it looks either too long (if it's just for crtm) or too short (if it's for the bundle). What is it supposed to be dependencies for? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @eap following up on Yannick's comment, what do these dependencies do? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are the end-to-end test dependencies (upstream and downstream) needed to build and run CRTM tests using the jedi bundle. Taken from Ben's comment here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I still don't see what it's supposed to be. If we want all the downstream repos, there should be a lot more. If it's just upstream there should be less. From the comment above, it's upstream and downstream, so the list should include all the model repos where crtm is used. |
||
test_strategy: INTEGRATION | ||
test_script: run_tests.sh | ||
bundle_repository: https://github.com/JCSDA/jedi-bundle.git | ||
target_repo_dir: target_repository | ||
bundle_branch: develop | ||
jedi_ci_token: ${{ steps.generate-token.outputs.token }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use master or main branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just casting a broad net here. This clause is the same on all repos which also makes global changes (which require scripted github interactions) a little easier.