-
Notifications
You must be signed in to change notification settings - Fork 0
Build config option to enable builds of "leaf-node" models in jedi-bundle. #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eap
commented
Sep 9, 2025
eap
commented
Sep 9, 2025
eap
commented
Sep 9, 2025
ashley314
reviewed
Sep 11, 2025
ashley314
approved these changes
Sep 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and changes satisfy the goal of the PR. Thanks!
eap
added a commit
to JCSDA/CRTMv3
that referenced
this pull request
Sep 12, 2025
Swap jedi-ci action branch back to deveop now that JCSDA-internal/jedi-ci#21 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the new "test_strategy" flag and replaces "unittest_dependencies" with test dependencies. This allows simplified builds for some "leaf-node" packages such as models. Middle-graph packages can also select more limited builds targeting packages that are known to be affected rather than building everything.
Strategies are as follows
ALL: Used for core dependencies like oops, ioda, ufo, etc. Runs two builds and two tests in this order: unit_build -> unit_test -> integration_build -> integration_testUNIT: Used for "leaf-node" packages like mpas-jedi and most models. Runs a single build with the specified dependencies and runs package unit testINTEGRATION: Used for "middle-graph" packages like CRTM. Runs a single build with the specified dependencies and runs all tests for the built packages.Examples:
Issues
Fixes: #27
Checklist