Resolve GNU compiler warnings in atmos_cubed submodule (#3196) // Create local backups of regression test log files (#3197)

[dpsarmie]

Commit Queue Requirements:

• This PR addresses a relevant WM issue (if not, create an issue).
• All subcomponent pull requests (if any) have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines), preferably on Ursa (Derecho or Hercules are acceptable alternatives). Exceptions: documentation-only PRs, CI-only PRs, etc.
  • Commit log file w/full results from RT suite run (if applicable).
  • Verify that test_changes.list indicates which tests, if any, are changed by this PR. Commit test_changes.list, even if it is empty.
• Fill out all sections of this template.

---

Description:

#3196

This PR will pull in changes to the atmos_cubed submodule to resolve all GNU compiler warnings. The warnings were being triggered due to extra characters occurring after #if or #endif commands. Since the extra text were usually descriptors, the descriptors were moved to comments before the #if or #endif commands.

After this PR, the only remaining GNU compiler warnings will be in UPP.

#3197

This PR modifies rt.sh to save a backup of the most recent regression test logs. This was a requested feature that can help users when they need to run multiple tests or if they accidentally spin off a test when it was not intended. The new backup files (added extension of .bak) will not be saved to the repository and the files have been added to .gitignore

Commit Message:

* UFSWM - Add capability to create regression test log backups
* UFSWM - Update UFSATM hash to bring in atmos_cubed warning fix
  * UFSATM - Update atmos_cubed hash to bring in warning fix
    * atmos_cubed_sphere - Remove trailing text after #if and #endif to fix GNU compiler warnings

Priority:

• Normal

Git Tracking

UFSWM:

• Closes Resolve GNU warnings in FV3 submodule #3195
• Closes Make a backup of previous RT log file before deleting #3188

Sub component Pull Requests:

• UFSATM: Update FV3 hash :: Removes all GNU compile warnings NOAA-EMC/ufsatm#1095
  • atmos_cubed_sphere: Fix GNU compiler warnings NOAA-GFDL/GFDL_atmos_cubed_sphere#412

UFSWM Blocking Dependencies:

• None

Documentation:

• Documentation update NOT required.

---

Changes

Regression Test Changes (Please commit test_changes.list):

• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Orion
  • Hercules
  • GaeaC6
  • Derecho
  • Ursa
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[gspetro-NOAA]

@dpsarmie Could you sync w/develop and combine in #3197 ?

[dpsarmie]

@gspetro-NOAA Ok, #3197 changes have been merged into this PR.

I'll sync now

[dpsarmie]

@gspetro-NOAA Ok, now this should be ready for testing.

[gspetro-NOAA]

@dpsarmie I don't see the most recent dev/emc atmos_cubed_sphere hash 9599114 in your branch, but I might be missing something. Could you take a look?

[dpsarmie]

@dpsarmie I don't see the most recent dev/emc atmos_cubed_sphere hash 9599114 in your branch, but I might be missing something. Could you take a look?

You're right. Updated the FV3 branch and it now has that hash in its history. Thanks for catching that. Take a look and see if everything else looks ok. I hope the CI issues are on GitHub's side and not with this PR (looks like it from the logs).

[gspetro-NOAA]

You're right. Updated the FV3 branch and it now has that hash in its history. Thanks for catching that. Take a look and see if everything else looks ok. I hope the CI issues are on GitHub's side and not with this PR (looks like it from the logs).

No worries! It looks good now. I reran repo_check, and it's passing. The log warnings aren't worth rerunning because logs have changed since you ran tests, which is likely the reason for the failure. It matters more that they were originally passing, which they were. The Spack CI is failing due to some 500 errors in fetching certain submodules. From what I can tell, it's supposed to be a transient thing and CI related rather than code-related, so I think we can move forward.

[dpsarmie]

Updated the UFSATM hash and reverted .gitmodules, this should be ready for final reviews.